Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap order of the two bibentry instances #449

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

conradsnicta
Copy link
Contributor

@conradsnicta conradsnicta commented Aug 1, 2024

@eddelbuettel The peer-reviewed article should be cited before the manual. Detailed reasoning given in email.

The peer-reviewed article should be cited before the manual.  Reasoning given in email.
@eddelbuettel
Copy link
Member

It would have helped if you had let have an hour or two to respond to your email (which arrived in the middle of my night).

@eddelbuettel eddelbuettel changed the title swap order of the two bibentry instances Swap order of the two bibentry instances Aug 1, 2024
@eddelbuettel
Copy link
Member

As per my email reply, we have more work to do on package metadata also influencing citation. We can do this here, or in separare PRs. I am mostly indifferent but it may make sense to hash it all out here. Thoughts?

@conradsnicta
Copy link
Contributor Author

separate PRs are preferred

@eddelbuettel
Copy link
Member

I lean towards doing it here in one PR dealing with 'citation() output'. But I will mull it over some more.

@conradsnicta
Copy link
Contributor Author

I'm time constrained, so the current PR is the best that I can do

@eddelbuettel
Copy link
Member

See email. For the related other part I need input from you, or else need to proceed with entries you may find suboptimal. Your call.

This is not urgent. CRAN is now closed for two weeks, and we aim to only upload "once every 1 - 2 months" (quoting their guidelines) to not overwhelm CRAN.

@eddelbuettel eddelbuettel merged commit 257f4fe into RcppCore:master Aug 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants