Skip to content

Conversation

romainfrancois
Copy link
Contributor

requiring Rcpp 0.10.6.2 so that you get the last fix that meant undoing Rmath macros early enough.

I've also changed functions so that they use attributes ([[Rcpp::export]])

dmbates and others added 30 commits June 23, 2011 14:55
…ays of doing this but I can't work out the syntax.
…rcing; add a suppressSVD argument to do_bench().
…the extension mechanism. Should make these legitimate iterators.
…tests to avoid the .eval() methods; bump Rcpp version dependence
@romainfrancois
Copy link
Contributor Author

Hmm. I need to fix .Call calls first.

@romainfrancois
Copy link
Contributor Author

ok so there was a corner case because Rcpp::exporting fastLm is creating a fastLmR function as part of the attributes business, so I've renamed the internal one fastLm_impl

@romainfrancois
Copy link
Contributor Author

travis is happy now. @dmbates I'll leave it to you to merge this if you like.

@dmbates
Copy link
Collaborator

dmbates commented Nov 15, 2013

@romainfrancois Which version of Rcpp should I be testing this with? I have installed the current master branch (9c5babc) and consistently get failures of the tests of the form

>   flm <- fastLmPure(mm, y)
Error in fastLm_impl(X, y, as.integer(method[1])) : 
  function 'enterRNGScope' not provided by package 'Rcpp'
Calls: fastLmPure -> fastLm_impl -> .Call

Remove Rcpp from the list of Imports: and add a version to it in LinkingTo:
@romainfrancois
Copy link
Contributor Author

I'll have a look. I should probably review in which namespace was each function before and put it in the same place.

but at least it works with released Rcpp (in travis it built).

@eddelbuettel
Copy link
Member

I corrected the .travis.yml in the headeronly branch to use Rcpp from Github; it fails with the very issue @dmbates noted here, see https://travis-ci.org/RcppCore/RcppEigen/builds/14053890

@romainfrancois
Copy link
Contributor Author

So:

>   flm <- fastLmPure(mm, y)
Error in fastLm_impl(X, y, as.integer(method[1])) : 
  function 'enterRNGScope' not provided by package 'Rcpp'
Calls: fastLmPure -> fastLm_impl -> .Call
Execution halted

That type of message would appear if the Rcpp has not been loaded, i.e. the R_init_Rcpp function has not been called.

I'm trying using Depends: Rcpp, or perhaps we can use useDynLib(Rcpp) in RcppEigen's namespace,

@romainfrancois
Copy link
Contributor Author

This closes the enterRNGScope problem, but has opened another set of issues;
https://travis-ci.org/RcppCore/RcppEigen#L1296

@romainfrancois
Copy link
Contributor Author

Probably irrelevant now.

@eddelbuettel
Copy link
Member

Yes.

RcppEigen is among the 157 out of 166 [ numbers as of now ] packages who work 'as-is'. See the rcpp-logs repository for details.

@eddelbuettel eddelbuettel deleted the Rcppheaderonly branch March 3, 2014 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants