Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't compile TikTok #35

Closed
MeDemon0 opened this issue Feb 24, 2024 · 3 comments · May be fixed by ReVanced/revanced-manager#1869
Closed

Can't compile TikTok #35

MeDemon0 opened this issue Feb 24, 2024 · 3 comments · May be fixed by ReVanced/revanced-manager#1869

Comments

@MeDemon0
Copy link

  • Device Info
    ReVanced Manager: 1.18.0
    Model: SM-G998B
    Android version: 14
    Supported architectures: arm64-v8a, armeabi-v7a, armeabi
    Root permissions: Yes

  • Patch Info
    App: com.zhiliaoapp.musically v32.5.3 (Suggested: v32.5.3)
    Patches version: v4.2.0
    Patches added: Default
    Patches removed: None
    Default patch options changed: None

  • Settings
    Allow changing patch selection: false
    Version compatibility check: true
    Show universal patches: false
    Patches source: revanced/revanced-patches
    Integration source: revanced/revanced-integrations

  • Logs
    Copying APK
    Reading APK
    Decoding app manifest
    Loading patches
    Merging integrations
    Executing patches
    Applied 8 patches
    Compiling patched dex files
    Compiled 22 dex files
    An error occurred:
    java.lang.OutOfMemoryError: Failed to allocate a 80 byte allocation with 3043016 free bytes and 2971KB until OOM, target footprint 536870912, growth limit 536870912; giving up on allocation because <1% of heap free after GC.
    at java.lang.StringFactory.newStringFromChars(StringFactory.java:124)
    at com.android.tools.smali.util.Utf8Utils.utf8BytesWithUtf16LengthToString(Utf8Utils.java:270)
    at com.android.tools.smali.dexlib2.dexbacked.DexReader.readString(DexReader.java:610)
    at com.android.tools.smali.dexlib2.dexbacked.DexBackedDexFile$5.get(DexBackedDexFile.java:336)
    at com.android.tools.smali.dexlib2.dexbacked.DexBackedDexFile$5.get(DexBackedDexFile.java:329)
    at com.android.tools.smali.dexlib2.dexbacked.DexBackedDexFile$6.get(DexBackedDexFile.java:372)
    at com.android.tools.smali.dexlib2.dexbacked.DexBackedDexFile$6.get(DexBackedDexFile.java:367)
    at com.android.tools.smali.dexlib2.dexbacked.reference.DexBackedMethodReference.getReturnType(DexBackedMethodReference.java:94)
    at com.android.tools.smali.dexlib2.writer.pool.PoolMethodProto.getReturnType(PoolMethodProto.java:53)
    at com.android.tools.smali.dexlib2.base.reference.BaseMethodProtoReference.compareTo(BaseMethodProtoReference.java:63)
    at com.android.tools.smali.dexlib2.base.reference.BaseMethodProtoReference.compareTo(BaseMethodProtoReference.java:43)
    at com.android.tools.smali.dexlib2.writer.DexWriter$3.compare(DexWriter.java:280)
    at com.android.tools.smali.dexlib2.writer.DexWriter$3.compare(DexWriter.java:278)
    at java.util.TimSort.mergeHi(TimSort.java:841)
    at java.util.TimSort.mergeAt(TimSort.java:520)
    at java.util.TimSort.mergeForceCollapse(TimSort.java:461)
    at java.util.TimSort.sort(TimSort.java:254)
    at java.util.Arrays.sort(Arrays.java:1344)
    at java.util.ArrayList.sort(ArrayList.java:1738)
    at java.util.Collections.sort(Collections.java:210)
    at com.android.tools.smali.dexlib2.writer.DexWriter.writeProtos(DexWriter.java:515)
    at com.android.tools.smali.dexlib2.writer.DexWriter.writeTo(DexWriter.java:385)
    at com.android.tools.smali.dexlib2.writer.DexWriter.writeTo(DexWriter.java:370)
    at lanchon.multidexlib2.DexIO.writeMultiDexDirectoryCommon(DexIO.java:162)
    at lanchon.multidexlib2.DexIO.access$000(DexIO.java:37)
    at lanchon.multidexlib2.DexIO$1.call(DexIO.java:102)
    at lanchon.multidexlib2.DexIO$1.call(DexIO.java:99)
    at java.util.concurrent.FutureTask.run(FutureTask.java:264)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:644)
    at java.lang.Thread.run(Thread.java:1012)

@oSumAtrIX
Copy link
Member

You'll need more RAM, use ReVanced CLI

@oSumAtrIX oSumAtrIX closed this as not planned Won't fix, can't repro, duplicate, stale Feb 24, 2024
@MeDemon0
Copy link
Author

You'll need more RAM, use ReVanced CLI

I did that already, I just thought this is a problem that needs to be addressed and fixed.

@oSumAtrIX
Copy link
Member

This is the wrong repository and the issue already exists

taylorkline added a commit to taylorkline/revanced-manager that referenced this issue Apr 16, 2024
Patching large applications (e.g. TikTok) on Android with multithreading simply doesn't work on multicore devices where the amount of memory given to the manager (regardless of the system RAM) is not sufficient.

It's more important that patching succeeds for all available use cases than for only some patching to succeed with faster performance. A UI option can be added later, but the multithreading option should be opt-out by default rather than opt-in.

Closes ReVanced/revanced-documentation#35
Closes ReVanced#1454
Closes ReVanced#1571
Closes ReVanced#1595
Closes ReVanced#1659
Closes ReVanced#1661
Closes ReVanced#1684
Closes ReVanced#1759
Closes ReVanced#1802
Closes ReVanced#1817
Closes ReVanced/revanced-manager#2885
Closes ReVanced#592
Closes ReVanced/revanced-patcher#193
Closes ReVanced/revanced-patches#1533
Closes ReVanced/revanced-patches#1608
Closes ReVanced/revanced-patches#1613
Closes ReVanced/revanced-patches#1630
Closes ReVanced/revanced-patches#190
Closes ReVanced/revanced-patches#2511
Closes ReVanced/revanced-patches#525
taylorkline added a commit to taylorkline/revanced-manager that referenced this issue Apr 16, 2024
Patching large applications (e.g. TikTok) on Android with multithreading simply doesn't work on multicore devices where the amount of memory given to the manager (regardless of the system RAM) is not sufficient.

It's more important that patching succeeds for all available use cases than for only some patching to succeed with faster performance. A UI option can be added later, but the multithreading option should be opt-out by default rather than opt-in.

Closes ReVanced/revanced-documentation#35
Closes ReVanced#1454
Closes ReVanced#1571
Closes ReVanced#1595
Closes ReVanced#1659
Closes ReVanced#1661
Closes ReVanced#1684
Closes ReVanced#1759
Closes ReVanced#1802
Closes ReVanced#1817
Closes ReVanced/revanced-patches#2885
Closes ReVanced#592
Closes ReVanced/revanced-patcher#193
Closes ReVanced/revanced-patches#1533
Closes ReVanced/revanced-patches#1608
Closes ReVanced/revanced-patches#1613
Closes ReVanced/revanced-patches#1630
Closes ReVanced/revanced-patches#190
Closes ReVanced/revanced-patches#2511
Closes ReVanced/revanced-patches#525
taylorkline added a commit to taylorkline/revanced-manager that referenced this issue Apr 16, 2024
Patching large applications (e.g. TikTok) on Android with multithreading simply doesn't work on multicore devices where the amount of memory given to the manager (regardless of the system RAM) is not sufficient.

It's more important that patching succeeds for all available use cases than for only some patching to succeed with faster performance. A UI option can be added later, but the multithreading option should be opt-out by default rather than opt-in.

Closes ReVanced/revanced-documentation#35
Closes ReVanced#1454
Closes ReVanced#1571
Closes ReVanced#1595
Closes ReVanced#1659
Closes ReVanced#1661
Closes ReVanced#1684
Closes ReVanced#1759
Closes ReVanced#1802
Closes ReVanced#1817
Closes ReVanced/revanced-patches#2885
Closes ReVanced#592
Closes ReVanced/revanced-patcher#193
Closes ReVanced/revanced-patches#1533
Closes ReVanced/revanced-patches#1608
Closes ReVanced/revanced-patches#1613
Closes ReVanced/revanced-patches#1630
Closes ReVanced/revanced-patches#190
Closes ReVanced/revanced-patches#2511
Closes ReVanced/revanced-patches#525
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants