Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Error Patching TikTok 27.3.3 #1613

Closed
3 tasks done
Solus32 opened this issue Dec 12, 2022 · 23 comments · May be fixed by ReVanced/revanced-manager#1869
Closed
3 tasks done

bug: Error Patching TikTok 27.3.3 #1613

Solus32 opened this issue Dec 12, 2022 · 23 comments · May be fixed by ReVanced/revanced-manager#1869
Labels
Bug report Something isn't working

Comments

@Solus32
Copy link

Solus32 commented Dec 12, 2022

Type

Error while patching

Bug description

Error while Patching TikTok 27.3.3 (com.zhiliaoapp.musically) using ReVanced Manager, all the versions of tiktok 27.3.x had errors while patching, but the versions of 27.2.x the Patch is successful

Steps to reproduce

Try to patch the last version of tiktok and select the patches --> Disable Login Requeriment, Feed Filter, Hide Ads, Sim Spoof.

Relevant log output

Initializing installer
Creating working directory
Copying original apk
Unpacking input apk
Reading dex files
Decoding AndroidManifest.xml only, because resources are not needed
Merging integrations
Applied disable-login-requirement
feed-filter failed.
Error:
kotlin.Unit
Applied hide-ads
settings failed.
Error:
kotlin.Unit
sim-spoof failed.
Error:
kotlin.Unit
Repacking patched apk
Not compiling resources because resource patching is not required
Writing modified dex files
An error occurred! Aborting
Error:
java.lang.OutOfMemoryError: Failed to allocate a 94936760 byte allocation with 25165824 free bytes and 63MB until OOM, target footprint 495212992, growth limit 536870912
	at java.util.Arrays.copyOf(Arrays.java:3161)
	at org.jf.dexlib2.writer.io.MemoryDataStore.growBufferIfNeeded(MemoryDataStore.java:61)
	at org.jf.dexlib2.writer.io.MemoryDataStore.access$000(MemoryDataStore.java:9)
	at org.jf.dexlib2.writer.io.MemoryDataStore$1.write(MemoryDataStore.java:49)
	at java.io.BufferedOutputStream.flushBuffer(BufferedOutputStream.java:82)
	at java.io.BufferedOutputStream.write(BufferedOutputStream.java:95)
	at org.jf.dexlib2.writer.DexDataWriter.write(DexDataWriter.java:76)
	at org.jf.dexlib2.writer.DebugWriter.writeSpecialOpcode(DebugWriter.java:159)
	at org.jf.dexlib2.writer.DebugWriter.writeLineNumber(DebugWriter.java:124)
	at org.jf.dexlib2.writer.pool.ClassPool.writeDebugItem(ClassPool.java:463)
	at org.jf.dexlib2.writer.DexWriter.writeDebugItem(DexWriter.java:1138)
	at org.jf.dexlib2.writer.DexWriter.writeDebugAndCodeItems(DexWriter.java:1039)
	at org.jf.dexlib2.writer.DexWriter.writeTo(DexWriter.java:346)
	at org.jf.dexlib2.writer.DexWriter.writeTo(DexWriter.java:301)
	at lanchon.multidexlib2.DexIO.writeMultiDexDirectoryCommon(DexIO.java:148)
	at lanchon.multidexlib2.DexIO.lambda$writeMultiDexDirectoryMultiThread$0(DexIO.java:92)
	at lanchon.multidexlib2.DexIO$$ExternalSyntheticLambda0.call(Unknown Source:12)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
	at java.lang.Thread.run(Thread.java:929)

Screenshots or videos

No response

Solution

No response

Additional context

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@Solus32 Solus32 added the Bug report Something isn't working label Dec 12, 2022
@Solus32
Copy link
Author

Solus32 commented Dec 12, 2022

My Android have 4 Gb of Ram, 128 GB of Storage, Android 10

@SCPF-Bot
Copy link

@Solus32

The current patch doesn't support that version or higher versions yet.

Currently, the latest supported version of the TikTok patches is the version 27.2.4.


Sample patching log of version 27.2.4:

PATCHING TIKTOK
INFO: Reading dex files 
INFO: Decoding AndroidManifest.xml only, because resources are not needed 
WARNING: Could not decode attr value, using undecoded value instead: ns=android, name=value, value=0x71020000 
INFO: Merging integrations.apk 
INFO: Skipping theme, reason: excluded by default 
INFO: Skipping debug-mode, reason: excluded by default 
INFO: Skipping compact-header, reason: excluded by default 
INFO: hide-ads succeeded 
INFO: playback-speed succeeded 
INFO: downloads succeeded 
INFO: show-seekbar succeeded 
INFO: settings succeeded 
INFO: fix-google-login succeeded 
INFO: disable-login-requirement succeeded 
INFO: sim-spoof succeeded 
INFO: feed-filter succeeded 
INFO: Not compiling resources because resource patching is not required 
INFO: Writing modified dex files 
INFO: Writing dex file classes.dex 
INFO: Writing dex file classes2.dex 
INFO: Writing dex file classes3.dex 
INFO: Writing dex file classes4.dex 
INFO: Writing dex file classes5.dex 
INFO: Writing dex file classes6.dex 
INFO: Writing dex file classes7.dex 
INFO: Writing dex file classes8.dex 
INFO: Writing dex file classes9.dex 
INFO: Writing dex file classes10.dex 
INFO: Writing dex file classes12.dex 
INFO: Writing dex file classes11.dex 
INFO: Writing dex file classes13.dex 
INFO: Writing dex file classes14.dex 
INFO: Writing dex file classes15.dex 
INFO: Writing dex file classes16.dex 
INFO: Writing dex file classes18.dex 
INFO: Writing dex file classes17.dex 
INFO: Aligning tiktok_raw.apk to tiktok_aligned.apk 
INFO: Signing tiktok_aligned.apk to tiktok_signed.apk

@oSumAtrIX
Copy link
Member

Your device is missing RAM to patch it, this is not an error of the patches.

@K4Z3R0
Copy link

K4Z3R0 commented Dec 12, 2022

I'm not sure why this error is happening, as it hasn't occurred in the past. Only TikTok seems to be experiencing this issue, while other apps like Reddit, Twitter, and YouTube are working fine.

@oSumAtrIX
Copy link
Member

That means patching TikTok requires more memory.

@K4Z3R0
Copy link

K4Z3R0 commented Dec 13, 2022

That means patching TikTok requires more memory.

I tried to use the ReVanced CLI, but some patches were broken and did not apply. Here is the full log.

@oSumAtrIX
Copy link
Member

You are using dev releases, use regular.

@K4Z3R0
Copy link

K4Z3R0 commented Dec 13, 2022

You are using dev releases, use regular.

I'm also experiencing the same error with the latest stable release of the CLI. By the way, I'm trying to patch the TikTok app version 27.3.4 (com.ss.android.ugc.trill).

@GH0STDATA
Copy link

GH0STDATA commented Dec 13, 2022

I'm also experiencing this problem. I even stepped down to version 27.2.3 and I'm still experiencing an error patching the APK. I'm using Revanced Builder, which uses the latest versions of Revanced-CLI and Revanced-Patches automatically. The same exact error occured on my phone with Revanced Manager as well. At this point, I think its an issue with the TikTok patches specifically. Patches for apps such as YouTube and Twitter worked perfectly fine for me.

Here is the log:

[builder] INFO: Reading dex files
[builder] INFO: Decoding AndroidManifest.xml only, because resources are not needed
[builder] WARNING: Could not decode attr value, using undecoded value instead: ns=android, name=value, value=0x71020000
[builder] INFO: Merging C:\Extra Programs\Revanced Builder\revanced\revanced-integrations-v0.84.0.apk
[builder] INFO: Skipping sim-spoof, reason: manually excluded
[builder] INFO: Skipping compact-header, reason: excluded by default
[builder] INFO: Skipping debug-mode, reason: excluded by default
[builder] INFO: Skipping theme, reason: excluded by default
[builder] WARNING: Skipping predictive-back-gesture, reason: Missing compatibility annotation. Continuing.
[builder] INFO: Deleting existing resource cache directory
[builder] SEVERE: Failed to delete existing resource cache directory
[builder] INFO: Decoding resources
[builder] WARNING: Could not decode attr value, using undecoded value instead: ns=android, name=value, value=0x71020000
[builder] WARNING: Cant find 9patch chunk in file: "o/gk.9.png". Renaming it to *.png.
[builder] WARNING: Cant find 9patch chunk in file: "o/gk.9.png". Renaming it to *.png.
[builder] WARNING: Cant find 9patch chunk in file: "o/gk.9.png". Renaming it to *.png.
[builder] WARNING: Cant find 9patch chunk in file: "o/gk.9.png". Renaming it to *.png.
[builder] WARNING: Cant find 9patch chunk in file: "o/gk.9.png". Renaming it to *.png.
[builder] WARNING: Cant find 9patch chunk in file: "o/gk.9.png". Renaming it to *.png.
[builder] WARNING: Cant find 9patch chunk in file: "o/gk.9.png". Renaming it to *.png.
[builder] WARNING: Cant find 9patch chunk in file: "o/gk.9.png". Renaming it to *.png.
[builder] WARNING: Cant find 9patch chunk in file: "o/gk.9.png". Renaming it to *.png.
[builder] WARNING: Cant find 9patch chunk in file: "o/gk.9.png". Renaming it to *.png.
[builder] WARNING: Cant find 9patch chunk in file: "o/gk.9.png". Renaming it to *.png.
[builder] WARNING: Cant find 9patch chunk in file: "o/gk.9.png". Renaming it to *.png.
[builder] WARNING: Cant find 9patch chunk in file: "o/gk.9.png". Renaming it to *.png.
[builder] WARNING: Cant find 9patch chunk in file: "o/gk.9.png". Renaming it to *.png.
[builder] WARNING: Cant find 9patch chunk in file: "o/gk.9.png". Renaming it to *.png.
[builder] WARNING: Cant find 9patch chunk in file: "o/gk.9.png". Renaming it to *.png.
[builder] WARNING: Cant find 9patch chunk in file: "o/gk.9.png". Renaming it to *.png.
[builder] WARNING: Cant find 9patch chunk in file: "o/gk.9.png". Renaming it to *.png.
[builder] WARNING: Cant find 9patch chunk in file: "o/gk.9.png". Renaming it to *.png.
[builder] WARNING: Cant find 9patch chunk in file: "o/gk.9.png". Renaming it to *.png.
[builder] WARNING: Cant find 9patch chunk in file: "o/gk.9.png". Renaming it to *.png.
[builder] WARNING: Cant find 9patch chunk in file: "o/gk.9.png". Renaming it to *.png.
[builder] WARNING: Cant find 9patch chunk in file: "o/gk.9.png". Renaming it to *.png.
[builder] WARNING: Cant find 9patch chunk in file: "o/gk.9.png". Renaming it to *.png.
[builder] WARNING: Cant find 9patch chunk in file: "o/gk.9.png". Renaming it to *.png.
[builder] WARNING: Cant find 9patch chunk in file: "o/gk.9.png". Renaming it to *.png.
[builder] WARNING: Cant find 9patch chunk in file: "o/gk.9.png". Renaming it to *.png.
[builder] WARNING: Cant find 9patch chunk in file: "o/gk.9.png". Renaming it to *.png.
[builder] WARNING: Cant find 9patch chunk in file: "o/gk.9.png". Renaming it to *.png.
[builder] WARNING: Cant find 9patch chunk in file: "o/gk.9.png". Renaming it to *.png.
[builder] WARNING: Cant find 9patch chunk in file: "o/gk.9.png". Renaming it to *.png.
[builder] INFO: show-seekbar succeeded
[builder] INFO: downloads succeeded
[builder] INFO: playback-speed succeeded
[builder] INFO: hide-ads succeeded
[builder] INFO: settings succeeded
[builder] INFO: fix-google-login succeeded
[builder] INFO: disable-login-requirement succeeded
[builder] INFO: feed-filter succeeded
[builder] INFO: predictive-back-gesture succeeded
[builder] INFO: Compiling resources
[builder] WARNING: C:\Extra Programs\Revanced Builder\.\revanced-cache\res\anim\a0.xml:3: error: not well-formed (invalid token).
[builder] WARNING: C:\Extra Programs\Revanced Builder\.\revanced-cache\res\anim\a0.xml: error: file failed to compile. WARNING: C:\Extra Programs\Revanced Builder\.\revanced-cache\res\anim\a1.xml:2: error: not well-formed (invalid token).
[builder] WARNING: C:\Extra Programs\Revanced Builder\.\revanced-cache\res\anim\a1.xml: error: file failed to compile.
[builder] WARNING: C:\Extra Programs\Revanced Builder\.\revanced-cache\res\anim\a2.xml:2: error: not well-formed (invalid token).
[builder] WARNING: C:\Extra Programs\Revanced Builder\.\revanced-cache\res\anim\a2.xml: error: file failed to compile.
[builder] WARNING: C:\Extra Programs\Revanced Builder\.\revanced-cache\res\anim\a3.xml:2: error: not well-formed (invalid token).
[builder] WARNING: C:\Extra Programs\Revanced Builder\.\revanced-cache\res\anim\a3.xml: error: file failed to compile.
[builder] WARNING: C:\Extra Programs\Revanced Builder\.\revanced-cache\res\anim\a4.xml:2: error: not well-formed (invalid token).
[builder] WARNING: C:\Extra Programs\Revanced Builder\.\revanced-cache\res\anim\a4.xml: error: file failed to compile.
[builder] WARNING: C:\Extra Programs\Revanced Builder\.\revanced-cache\res\anim\a5.xml:2: error: not well-formed (invalid token).
[builder] WARNING: C:\Extra Programs\Revanced Builder\.\revanced-cache\res\anim\a5.xml: error: file failed to compile.
[builder] WARNING: C:\Extra Programs\Revanced Builder\.\revanced-cache\res\anim\a6.xml:3: error: not well-formed (invalid token).
[builder] WARNING: C:\Extra Programs\Revanced Builder\.\revanced-cache\res\anim\a6.xml: error: file failed to compile.
[builder] WARNING: C:\Extra Programs\Revanced Builder\.\revanced-cache\res\anim\a7.xml:3: error: not well-formed (invalid token).
[builder] WARNING: C:\Extra Programs\Revanced Builder\.\revanced-cache\res\anim\a7.xml: error: file failed to compile.
[builder] WARNING: C:\Extra Programs\Revanced Builder\.\revanced-cache\res\anim\a8.xml:3: error: not well-formed (invalid token).
[builder] WARNING: C:\Extra Programs\Revanced Builder\.\revanced-cache\res\anim\a8.xml: error: file failed to compile.
[builder] WARNING: C:\Extra Programs\Revanced Builder\.\revanced-cache\res\anim\ac.xml:2: error: not well-formed (invalid token).
[builder] WARNING: C:\Extra Programs\Revanced Builder\.\revanced-cache\res\anim\ac.xml: error: file failed to compile.
[builder] brut.androlib.AndrolibException: brut.common.BrutException: could not exec (exit code = 1): [C:\Users\Komi-san\AppData\Local\Temp\brut_util_Jar_171726499316705341622351207526336315184.tmp, compile, --dir, C:\Extra Programs\Revanced Builder\.\revanced-cache\res, --legacy, -o, C:\Extra Programs\Revanced Builder\.\revanced-cache\build\resources.zip] at brut.androlib.res.AndrolibResources.aapt2Package(AndrolibResources.java:375) at brut.androlib.res.AndrolibResources.aaptPackage(AndrolibResources.java:629) at app.revanced.patcher.Patcher.save(Patcher.kt:148) at app.revanced.cli.patcher.Patcher.start$revanced_cli(Patcher.kt:33) at app.revanced.cli.command.MainCommand.run(MainCommand.kt:157) at picocli.CommandLine.executeUserObject(CommandLine.java:2026) at picocli.CommandLine.access$1500(CommandLine.java:148) at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461) at picocli.CommandLine$RunLast.handle(CommandLine.java:2453) at picocli.CommandLine$RunLast.handle(CommandLine.java:2415) at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273) at picocli.CommandLine$RunLast.execute(CommandLine.java:2417) at picocli.CommandLine.execute(CommandLine.java:2170) at app.revanced.cli.main.MainKt.main(Main.kt:7) Caused by: brut.common.BrutException: could not exec (exit code = 1): [C:\Users\Komi-san\AppData\Local\Temp\brut_util_Jar_171726499316705341622351207526336315184.tmp, compile, --dir, C:\Extra Programs\Revanced Builder\.\revanced-cache\res, --legacy, -o, C:\Extra Programs\Revanced Builder\.\revanced-cache\build\resources.zip] at brut.util.OS.exec(OS.java:99) at brut.androlib.res.AndrolibResources.aapt2Package(AndrolibResources.java:371) ... 13 more

@oSumAtrIX
Copy link
Member

@GH0STDATA I was responding to @KazKaz90:

image

@oSumAtrIX
Copy link
Member

I already read that @KazKaz90.

@GH0STDATA
Copy link

GH0STDATA commented Dec 13, 2022

@GH0STDATA I was responding to @KazKaz90:

image

@oSumAtrIX I know, I was just specifying that the issue has nothing to do with it being a dev build, it is occuring on the stable build of Revanced-CLI as well. I've edited my post above just to clarify. :)

@oSumAtrIX
Copy link
Member

@GH0STDATA As previosly mentioned I already know.

@GH0STDATA
Copy link

Oh okay, I apologize if the comment seemed repetitive. I'll leave my comment up since it seems to affect versions before 27.3.X as well.

@oSumAtrIX
Copy link
Member

If possible, find which version worked last, or which patches worked last.

@GH0STDATA
Copy link

Now that I look at it, it seems to be trying to merge a patch that isn't even available in the list of patches for TikTok: INFO: predictive-back-gesture succeeded

I've selected every patch individually and tried to only install one patch at a time, and that predictive back gesture patch keeps trying to be installed even though its not a selectable option. Do you think this might be causing the error to occur?

@oSumAtrIX
Copy link
Member

Sounds like the ReVanced Manager is not displaying patches, if they do not have a Compatibility annotation present. You might want to open an issue in the revanced-manager repository for that.

@GH0STDATA
Copy link

Yeah, I was just about to mention that: WARNING: Skipping predictive-back-gesture, reason: Missing compatibility annotation. Continuing.

Then it tries to install it anyway even though its not compatible. I'll open an issue now.

@Ushie
Copy link
Member

Ushie commented Dec 13, 2022

Sounds like the ReVanced Manager is not displaying patches, if they do not have a Compatibility annotation present. You might want to open an issue in the revanced-manager repository for that.

ReVanced Manager does display shared patches since ReVanced/revanced-manager#577

@GH0STDATA
Copy link

GH0STDATA commented Dec 13, 2022

This seems to be more of a Revanced-CLI issue. If you look at the log here, you'll see that it's trying to install a specific patch predictive-back-gesture, but it does not even know if its compatible with the app its being installed to. It's also not showing up at all in the list of patches either, so I'm not sure why its trying to install it if it wasn't even selected.

Edit: Turns out this was a Revanced Builder problem. ReVanced Manager works fine with v0.0.49.

@Ushie
Copy link
Member

Ushie commented Dec 13, 2022

This seems to be more of a Revanced-CLI issue. If you look at the log here, you'll see that it's trying to install a specific patch predictive-back-gesture, but it does not even know if its compatible with the app its being installed to. It's also not showing up at all in the list of patches either, so I'm not sure why its trying to install it if it wasn't even selected.

ReVanced doesn't support ReVanced Builder, please open an issue on the ReVanced Builder repository.

@GH0STDATA
Copy link

GH0STDATA commented Dec 13, 2022

The same issue was happening on ReVanced Manager as well, but it looks like an update was released for the APK just now lol. I've retried with the new update and it seems to work now. I'll open an issue with ReVanced Builder to let them know.

Edit: Now the update was removed? I'm very confused here, I just downloaded 0.0.49 a few minutes ago and now its gone 🤣

@K4Z3R0
Copy link

K4Z3R0 commented Dec 14, 2022

If possible, find which version worked last, or which patches worked last.

I successfully patched TikTok version 27.2.3 and tried every patch except for playback-speed, sim-spoof and the new predictive-back-gesture. However, I am now encountering a different error when attempting to patch 27.3.X using ReVanced Manager 0.0.48.

The error (OutOfMemoryError) before was the same with the OP but now it's different

Here's the log:

Creating working directory
Copying original apk
Unpacking input apk
Reading dex files
Decoding AndroidManifest.xml only, because resources are not needed
Merging integrations
An error occurred! Aborting
Error:
org.jf.dexlib2.DexFileFactory$DexFileNotFoundException: Could not find entry classes.dex in /data/user/0/app.revanced.manager.flutter/cache/libCachedImageData/3f4c8850-7b4a-11ed-8f31-e73c6902afc1.bin.
	at org.jf.dexlib2.DexFileFactory$DexEntryFinder.findEntry(DexFileFactory.java:393)
	at org.jf.dexlib2.DexFileFactory.loadDexFile(DexFileFactory.java:88)
	at org.jf.dexlib2.DexFileFactory.loadDexFile(DexFileFactory.java:61)
	at app.revanced.patcher.util.patch.PatchBundle$Dex.loadPatches(PatchBundle.kt:71)
	at app.revanced.manager.flutter.MainActivity.runPatcher$lambda$20(MainActivity.kt:176)
	at app.revanced.manager.flutter.MainActivity.$r8$lambda$VzOqgSVOualTn6WBlAKw3muxHF8(Unknown Source:0)
	at app.revanced.manager.flutter.MainActivity$$ExternalSyntheticLambda13.run(Unknown Source:24)
	at java.lang.Thread.run(Thread.java:919)

taylorkline added a commit to taylorkline/revanced-manager that referenced this issue Apr 16, 2024
Patching large applications (e.g. TikTok) on Android with multithreading simply doesn't work on multicore devices where the amount of memory given to the manager (regardless of the system RAM) is not sufficient.

It's more important that patching succeeds for all available use cases than for only some patching to succeed with faster performance. A UI option can be added later, but the multithreading option should be opt-out by default rather than opt-in.

Closes ReVanced/revanced-documentation#35
Closes ReVanced#1454
Closes ReVanced#1571
Closes ReVanced#1595
Closes ReVanced#1659
Closes ReVanced#1661
Closes ReVanced#1684
Closes ReVanced#1759
Closes ReVanced#1802
Closes ReVanced#1817
Closes ReVanced/revanced-manager#2885
Closes ReVanced#592
Closes ReVanced/revanced-patcher#193
Closes ReVanced/revanced-patches#1533
Closes ReVanced/revanced-patches#1608
Closes ReVanced/revanced-patches#1613
Closes ReVanced/revanced-patches#1630
Closes ReVanced/revanced-patches#190
Closes ReVanced/revanced-patches#2511
Closes ReVanced/revanced-patches#525
taylorkline added a commit to taylorkline/revanced-manager that referenced this issue Apr 16, 2024
Patching large applications (e.g. TikTok) on Android with multithreading simply doesn't work on multicore devices where the amount of memory given to the manager (regardless of the system RAM) is not sufficient.

It's more important that patching succeeds for all available use cases than for only some patching to succeed with faster performance. A UI option can be added later, but the multithreading option should be opt-out by default rather than opt-in.

Closes ReVanced/revanced-documentation#35
Closes ReVanced#1454
Closes ReVanced#1571
Closes ReVanced#1595
Closes ReVanced#1659
Closes ReVanced#1661
Closes ReVanced#1684
Closes ReVanced#1759
Closes ReVanced#1802
Closes ReVanced#1817
Closes ReVanced/revanced-patches#2885
Closes ReVanced#592
Closes ReVanced/revanced-patcher#193
Closes ReVanced/revanced-patches#1533
Closes ReVanced/revanced-patches#1608
Closes ReVanced/revanced-patches#1613
Closes ReVanced/revanced-patches#1630
Closes ReVanced/revanced-patches#190
Closes ReVanced/revanced-patches#2511
Closes ReVanced/revanced-patches#525
taylorkline added a commit to taylorkline/revanced-manager that referenced this issue Apr 16, 2024
Patching large applications (e.g. TikTok) on Android with multithreading simply doesn't work on multicore devices where the amount of memory given to the manager (regardless of the system RAM) is not sufficient.

It's more important that patching succeeds for all available use cases than for only some patching to succeed with faster performance. A UI option can be added later, but the multithreading option should be opt-out by default rather than opt-in.

Closes ReVanced/revanced-documentation#35
Closes ReVanced#1454
Closes ReVanced#1571
Closes ReVanced#1595
Closes ReVanced#1659
Closes ReVanced#1661
Closes ReVanced#1684
Closes ReVanced#1759
Closes ReVanced#1802
Closes ReVanced#1817
Closes ReVanced/revanced-patches#2885
Closes ReVanced#592
Closes ReVanced/revanced-patcher#193
Closes ReVanced/revanced-patches#1533
Closes ReVanced/revanced-patches#1608
Closes ReVanced/revanced-patches#1613
Closes ReVanced/revanced-patches#1630
Closes ReVanced/revanced-patches#190
Closes ReVanced/revanced-patches#2511
Closes ReVanced/revanced-patches#525
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants