Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: TikTok Memory #1533

Closed
3 tasks done
ripnonfegames opened this issue Dec 24, 2022 · 16 comments · May be fixed by ReVanced/revanced-manager#1869
Closed
3 tasks done

bug: TikTok Memory #1533

ripnonfegames opened this issue Dec 24, 2022 · 16 comments · May be fixed by ReVanced/revanced-manager#1869
Labels
Bug report Something isn't working

Comments

@ripnonfegames
Copy link

ripnonfegames commented Dec 24, 2022

Type

Error while patching

Bug description

I was patching TikTok and it said aborting due to memory error.

Steps to reproduce

  1. Patch TikTok with 5 selected patches.
    Disable Login Requirement
    Downloads
    Hide Ads
    Show seekbar and SIM spoof

Relevant log output

Initializing installer
Creating working directory
Copying original apk
Unpacking input apk
Reading dex files
Decoding AndroidManifest.xml only, because resources are not needed
Merging integrations
Applied disable-login-requirement
Applied downloads
Applied hide-ads
Applied settings
Applied show-seekbar
Applied sim-spoof
Repacking patched apk
Not compiling resources because resource patching is not required
Writing modified dex files
An error occurred! Aborting
Error:
java.lang.OutOfMemoryError: Failed to allocate a 60476232 byte allocation with 65264 free bytes and 63KB until OOM, target footprint 536870912, growth limit 536870912
	at java.util.Arrays.copyOf(Arrays.java:3161)
	at org.jf.dexlib2.writer.io.MemoryDataStore.growBufferIfNeeded(MemoryDataStore.java:61)
	at org.jf.dexlib2.writer.io.MemoryDataStore.access$000(MemoryDataStore.java:9)
	at org.jf.dexlib2.writer.io.MemoryDataStore$1.write(MemoryDataStore.java:49)
	at java.io.BufferedOutputStream.flushBuffer(BufferedOutputStream.java:82)
	at java.io.BufferedOutputStream.flush(BufferedOutputStream.java:140)
	at java.io.FilterOutputStream.close(FilterOutputStream.java:179)
	at org.jf.dexlib2.writer.DexWriter.writeTo(DexWriter.java:354)
	at org.jf.dexlib2.writer.DexWriter.writeTo(DexWriter.java:301)
	at lanchon.multidexlib2.DexIO.writeMultiDexDirectoryCommon(DexIO.java:148)
	at lanchon.multidexlib2.DexIO.lambda$writeMultiDexDirectoryMultiThread$0(DexIO.java:92)
	at lanchon.multidexlib2.DexIO$$ExternalSyntheticLambda0.call(Unknown Source:12)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
	at java.lang.Thread.run(Thread.java:920)

Screenshots or videos

No response

Solution

No response

Additional context

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@ripnonfegames ripnonfegames added the Bug report Something isn't working label Dec 24, 2022
@Starmania
Copy link
Contributor

Starmania commented Dec 24, 2022

Does your phone is a potato ? Ok I should have probably delete that long time ago, why did I ever wrote that... Sorry @ripnonfegames

@ripnonfegames
Copy link
Author

Does your phone is a potato ?

I have 12GB of ram, so no.

@ripnonfegames ripnonfegames changed the title bug: Memory bug: TikTok Memory Dec 24, 2022
@K4Z3R0
Copy link

K4Z3R0 commented Dec 24, 2022

ReVanced/revanced-patches-template#1613

@ripnonfegames
Copy link
Author

ReVanced/revanced-patches-template#1613

I saw that but there's no clear answer.

@K4Z3R0
Copy link

K4Z3R0 commented Dec 26, 2022

It seems like you might need more RAM, just like what Osumatrix said 😅

@Starmania
Copy link
Contributor

If you really have 12GB of RAM, try patch older one (and send the first older version that work for anyone having the same problem)

@shaiws

This comment was marked as spam.

@ghaschel

This comment was marked as spam.

@xscd
Copy link

xscd commented Jan 15, 2023

photo_2023-01-15_19-29-13

This hasn't been fixed even with the latest revanced-patcher update. can it be re-opened?

@oSumAtrIX
Copy link
Member

There is no release yet. It has been fixed in upstream.

@geiszla
Copy link

geiszla commented May 10, 2023

Is it still not released? I'm still having problems on the latest version (with the latest TikTok apk).

Edit: same happens with latest Twitter APK

@ripnonfegames
Copy link
Author

Why was this set as completed? I'm still having the problem

@oSumAtrIX
Copy link
Member

The issue was closed because it was solved. Open a new issue if you experience it

@ripnonfegames
Copy link
Author

but it's my ticket

@oSumAtrIX
Copy link
Member

Yes, but it is outdated, open a new one with the updated info

@VishramKidPG123

This comment was marked as spam.

@revanced-bot revanced-bot transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@oSumAtrIX oSumAtrIX transferred this issue from another repository Dec 14, 2023
taylorkline added a commit to taylorkline/revanced-manager that referenced this issue Apr 16, 2024
Patching large applications (e.g. TikTok) on Android with multithreading simply doesn't work on multicore devices where the amount of memory given to the manager (regardless of the system RAM) is not sufficient.

It's more important that patching succeeds for all available use cases than for only some patching to succeed with faster performance. A UI option can be added later, but the multithreading option should be opt-out by default rather than opt-in.

Closes ReVanced/revanced-documentation#35
Closes ReVanced#1454
Closes ReVanced#1571
Closes ReVanced#1595
Closes ReVanced#1659
Closes ReVanced#1661
Closes ReVanced#1684
Closes ReVanced#1759
Closes ReVanced#1802
Closes ReVanced#1817
Closes ReVanced/revanced-manager#2885
Closes ReVanced#592
Closes ReVanced/revanced-patcher#193
Closes ReVanced/revanced-patches#1533
Closes ReVanced/revanced-patches#1608
Closes ReVanced/revanced-patches#1613
Closes ReVanced/revanced-patches#1630
Closes ReVanced/revanced-patches#190
Closes ReVanced/revanced-patches#2511
Closes ReVanced/revanced-patches#525
taylorkline added a commit to taylorkline/revanced-manager that referenced this issue Apr 16, 2024
Patching large applications (e.g. TikTok) on Android with multithreading simply doesn't work on multicore devices where the amount of memory given to the manager (regardless of the system RAM) is not sufficient.

It's more important that patching succeeds for all available use cases than for only some patching to succeed with faster performance. A UI option can be added later, but the multithreading option should be opt-out by default rather than opt-in.

Closes ReVanced/revanced-documentation#35
Closes ReVanced#1454
Closes ReVanced#1571
Closes ReVanced#1595
Closes ReVanced#1659
Closes ReVanced#1661
Closes ReVanced#1684
Closes ReVanced#1759
Closes ReVanced#1802
Closes ReVanced#1817
Closes ReVanced/revanced-patches#2885
Closes ReVanced#592
Closes ReVanced/revanced-patcher#193
Closes ReVanced/revanced-patches#1533
Closes ReVanced/revanced-patches#1608
Closes ReVanced/revanced-patches#1613
Closes ReVanced/revanced-patches#1630
Closes ReVanced/revanced-patches#190
Closes ReVanced/revanced-patches#2511
Closes ReVanced/revanced-patches#525
taylorkline added a commit to taylorkline/revanced-manager that referenced this issue Apr 16, 2024
Patching large applications (e.g. TikTok) on Android with multithreading simply doesn't work on multicore devices where the amount of memory given to the manager (regardless of the system RAM) is not sufficient.

It's more important that patching succeeds for all available use cases than for only some patching to succeed with faster performance. A UI option can be added later, but the multithreading option should be opt-out by default rather than opt-in.

Closes ReVanced/revanced-documentation#35
Closes ReVanced#1454
Closes ReVanced#1571
Closes ReVanced#1595
Closes ReVanced#1659
Closes ReVanced#1661
Closes ReVanced#1684
Closes ReVanced#1759
Closes ReVanced#1802
Closes ReVanced#1817
Closes ReVanced/revanced-patches#2885
Closes ReVanced#592
Closes ReVanced/revanced-patcher#193
Closes ReVanced/revanced-patches#1533
Closes ReVanced/revanced-patches#1608
Closes ReVanced/revanced-patches#1613
Closes ReVanced/revanced-patches#1630
Closes ReVanced/revanced-patches#190
Closes ReVanced/revanced-patches#2511
Closes ReVanced/revanced-patches#525
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants