-
-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: <TikTok Failed patching> #1661
Labels
Bug report
Something isn't working
Comments
taylorkline
added a commit
to taylorkline/revanced-manager
that referenced
this issue
Apr 16, 2024
Patching large applications (e.g. TikTok) on Android with multithreading simply doesn't work on multicore devices where the amount of memory given to the manager (regardless of the system RAM) is not sufficient. It's more important that patching succeeds for all available use cases than for only some patching to succeed with faster performance. A UI option can be added later, but the multithreading option should be opt-out by default rather than opt-in. Closes ReVanced/revanced-documentation#35 Closes ReVanced#1454 Closes ReVanced#1571 Closes ReVanced#1595 Closes ReVanced#1659 Closes ReVanced#1661 Closes ReVanced#1684 Closes ReVanced#1759 Closes ReVanced#1802 Closes ReVanced#1817 Closes ReVanced/revanced-manager#2885 Closes ReVanced#592 Closes ReVanced/revanced-patcher#193 Closes ReVanced/revanced-patches#1533 Closes ReVanced/revanced-patches#1608 Closes ReVanced/revanced-patches#1613 Closes ReVanced/revanced-patches#1630 Closes ReVanced/revanced-patches#190 Closes ReVanced/revanced-patches#2511 Closes ReVanced/revanced-patches#525
taylorkline
added a commit
to taylorkline/revanced-manager
that referenced
this issue
Apr 16, 2024
Patching large applications (e.g. TikTok) on Android with multithreading simply doesn't work on multicore devices where the amount of memory given to the manager (regardless of the system RAM) is not sufficient. It's more important that patching succeeds for all available use cases than for only some patching to succeed with faster performance. A UI option can be added later, but the multithreading option should be opt-out by default rather than opt-in. Closes ReVanced/revanced-documentation#35 Closes ReVanced#1454 Closes ReVanced#1571 Closes ReVanced#1595 Closes ReVanced#1659 Closes ReVanced#1661 Closes ReVanced#1684 Closes ReVanced#1759 Closes ReVanced#1802 Closes ReVanced#1817 Closes ReVanced/revanced-patches#2885 Closes ReVanced#592 Closes ReVanced/revanced-patcher#193 Closes ReVanced/revanced-patches#1533 Closes ReVanced/revanced-patches#1608 Closes ReVanced/revanced-patches#1613 Closes ReVanced/revanced-patches#1630 Closes ReVanced/revanced-patches#190 Closes ReVanced/revanced-patches#2511 Closes ReVanced/revanced-patches#525
taylorkline
added a commit
to taylorkline/revanced-manager
that referenced
this issue
Apr 16, 2024
Patching large applications (e.g. TikTok) on Android with multithreading simply doesn't work on multicore devices where the amount of memory given to the manager (regardless of the system RAM) is not sufficient. It's more important that patching succeeds for all available use cases than for only some patching to succeed with faster performance. A UI option can be added later, but the multithreading option should be opt-out by default rather than opt-in. Closes ReVanced/revanced-documentation#35 Closes ReVanced#1454 Closes ReVanced#1571 Closes ReVanced#1595 Closes ReVanced#1659 Closes ReVanced#1661 Closes ReVanced#1684 Closes ReVanced#1759 Closes ReVanced#1802 Closes ReVanced#1817 Closes ReVanced/revanced-patches#2885 Closes ReVanced#592 Closes ReVanced/revanced-patcher#193 Closes ReVanced/revanced-patches#1533 Closes ReVanced/revanced-patches#1608 Closes ReVanced/revanced-patches#1613 Closes ReVanced/revanced-patches#1630 Closes ReVanced/revanced-patches#190 Closes ReVanced/revanced-patches#2511 Closes ReVanced/revanced-patches#525
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug description
Tried patching TikTok but a failed message appeared. Tried once more and got the same message again.
Version of ReVanced Manager and version & name of application you tried to patch
ReVanced Manager 1.18
TikTok 32.5.3
Installation type
Non-root
Device logs
Patcher logs
No response
Acknowledgements
The text was updated successfully, but these errors were encountered: