Skip to content
This repository has been archived by the owner on Oct 26, 2024. It is now read-only.

feat: Move strings to resources for localization #420

Merged
merged 111 commits into from
Jan 27, 2024

Conversation

LisoUseInAIKyrios
Copy link
Contributor

@LisoUseInAIKyrios LisoUseInAIKyrios commented Jun 6, 2023

integration changes for ReVanced/revanced-patches#2440

Changes made:

  • Added 'revanced_' prefix to RYD and SB strings
  • Localized the last strings that were hard coded
  • Added '_intent' suffix to settings intent (ie: "sponsorblock_settings" changed to "sponsorblock_settings_intent")
  • Include device language as parameter to ReVanced Announcement api call (if that is ever localized in the future).
  • Sorts setting menus using the language in use

@LisoUseInAIKyrios LisoUseInAIKyrios marked this pull request as ready for review June 15, 2023 07:26
…o specify a fixed preference menu ordering, all were either too clunky or just did not work quite right.

For now just use a fixed depth to sort to, and leave all the deeper submenus in the order the patch specifies.
@oSumAtrIX
Copy link
Member

oSumAtrIX commented Jan 24, 2024

Once the PR #549 is undrafted, it should be merged into this one. Likewise, the patches counterpart of that PR will be merged (force-pushed) to, the counterpart of this PR

@oSumAtrIX oSumAtrIX changed the title feat(Translations): Translations for YouTube and Twitch feat(AddResourcesPatch): Support adding resources directly from the patch resources with localization for strings in mind Jan 26, 2024
@oSumAtrIX oSumAtrIX marked this pull request as draft January 26, 2024 00:19
@oSumAtrIX oSumAtrIX marked this pull request as ready for review January 27, 2024 00:56
@oSumAtrIX oSumAtrIX changed the title feat(AddResourcesPatch): Support adding resources directly from the patch resources with localization for strings in mind feat: Support adding resources directly from the patch resources with localization for strings in mind Jan 27, 2024
@oSumAtrIX oSumAtrIX changed the title feat: Support adding resources directly from the patch resources with localization for strings in mind feat: Move strings to resources for localization Jan 27, 2024
@LisoUseInAIKyrios

This comment was marked as resolved.

@oSumAtrIX

This comment was marked as resolved.

@LisoUseInAIKyrios

This comment was marked as resolved.

@oSumAtrIX oSumAtrIX merged commit e2a7e85 into ReVanced:dev Jan 27, 2024
2 checks passed
@LisoUseInAIKyrios LisoUseInAIKyrios deleted the localization branch January 27, 2024 01:35
revanced-bot pushed a commit that referenced this pull request Jan 27, 2024
# [2.0.0-dev.1](v1.2.0-dev.2...v2.0.0-dev.1) (2024-01-27)

### Features

* Move strings to resources for localization ([#420](#420)) ([e2a7e85](e2a7e85))

### BREAKING CHANGES

* Various APIs have been changed.
oSumAtrIX added a commit that referenced this pull request Jan 27, 2024
Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
Co-authored-by: oSumAtrIX <johan.melkonyan1@web.de>
revanced-bot pushed a commit that referenced this pull request Jan 27, 2024
# [1.2.0-dev.3](v1.2.0-dev.2...v1.2.0-dev.3) (2024-01-27)

### Features

* Move strings to resources for localization ([#420](#420)) ([7ae10be](7ae10be))
* **YouTube - Spoof app version:** Add `18.09.39` to restore library tab ([#552](#552)) ([3bd48dc](3bd48dc))
revanced-bot pushed a commit that referenced this pull request Jan 27, 2024
# [1.2.0](v1.1.0...v1.2.0) (2024-01-27)

### Bug Fixes

* **YouTube - DeArrow:** Correctly handle http status 304 ([3e380df](3e380df))
* **YouTube - Hide ads:** Do not leave screen at launch non interactable when hiding fullscreen ads ([fbdb490](fbdb490))
* **YouTube - Hide ads:** Fix dimmed screen at launch by not filtering fullscreen ads ([1a1f44d](1a1f44d))
* **YouTube - Settings:** Correctly initialize default values ([752544b](752544b))
* **YouTube - SponsorBlock:** Update categories after import JSON import ([211f954](211f954))

### Features

* Move strings to resources for localization ([#420](#420)) ([7ae10be](7ae10be))
* **Tiktok - Playback speed:** Remember playback speed ([#543](#543)) ([21ced14](21ced14))
* **YouTube - Spoof app version:** Add `18.09.39` to restore library tab ([#552](#552)) ([3bd48dc](3bd48dc))
* **YouTube:** Support versions `18.48.39`, `18.49.37`, `19.01.34` ([#547](#547)) ([eaaa6fb](eaaa6fb))
E85Addict pushed a commit to E85Addict/revanced-integrations that referenced this pull request Jan 27, 2024
# [1.2.0](v1.1.0...v1.2.0) (2024-01-27)

### Bug Fixes

* **YouTube - DeArrow:** Correctly handle http status 304 ([3e380df](3e380df))
* **YouTube - Hide ads:** Do not leave screen at launch non interactable when hiding fullscreen ads ([fbdb490](fbdb490))
* **YouTube - Hide ads:** Fix dimmed screen at launch by not filtering fullscreen ads ([1a1f44d](1a1f44d))
* **YouTube - Settings:** Correctly initialize default values ([752544b](752544b))
* **YouTube - SponsorBlock:** Update categories after import JSON import ([211f954](211f954))

### Features

* Move strings to resources for localization ([ReVanced#420](https://github.com/E85Addict/revanced-integrations/issues/420)) ([7ae10be](7ae10be))
* **Tiktok - Playback speed:** Remember playback speed ([ReVanced#543](https://github.com/E85Addict/revanced-integrations/issues/543)) ([21ced14](21ced14))
* **YouTube - Spoof app version:** Add `18.09.39` to restore library tab ([ReVanced#552](https://github.com/E85Addict/revanced-integrations/issues/552)) ([3bd48dc](3bd48dc))
* **YouTube:** Support versions `18.48.39`, `18.49.37`, `19.01.34` ([ReVanced#547](https://github.com/E85Addict/revanced-integrations/issues/547)) ([eaaa6fb](eaaa6fb))

### Performance Improvements

* Add upstream sync ([752a49c](752a49c))
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants