Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: init #1224

Merged
merged 3 commits into from
Sep 26, 2023
Merged

docs: init #1224

merged 3 commits into from
Sep 26, 2023

Conversation

BenjaminHalko
Copy link
Member

@BenjaminHalko BenjaminHalko commented Sep 1, 2023 •
edited
Loading

Now it is slightly clearer how to build the manager.

TODO:

@BenjaminHalko BenjaminHalko added the ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager label Sep 1, 2023
@BenjaminHalko BenjaminHalko mentioned this pull request Sep 1, 2023
Closed
1 task
@validcube validcube changed the title docs-compose: Added Build Steps docs: Added Build Steps Sep 2, 2023
@BenjaminHalko BenjaminHalko changed the title docs: Added Build Steps docs: added build steps Sep 3, 2023
@oSumAtrIX
Copy link
Member

oSumAtrIX commented Sep 19, 2023 •
edited
Loading

Building steps are under /docs:

https://github.com/ReVanced/revanced-manager/blob/main/docs/4_building.md

The docs structure should be retained the way it is in main right now.

@oSumAtrIX oSumAtrIX marked this pull request as draft September 19, 2023 02:12
@BenjaminHalko BenjaminHalko changed the title docs: added build steps docs: init Sep 20, 2023
@BenjaminHalko BenjaminHalko linked an issue Sep 20, 2023 that may be closed by this pull request
docs: Update the docs to match the latest changes #1234
Open
@BenjaminHalko
Copy link
Member Author

@oSumAtrIX done

oSumAtrIX
oSumAtrIX requested changes Sep 26, 2023
View reviewed changes
Copy link
Member

@oSumAtrIX oSumAtrIX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with the docs there is one more workflow associated to dispatch an event on pushes to /docs. Please add it to this PR.

@BenjaminHalko BenjaminHalko marked this pull request as ready for review September 26, 2023 23:50
@BenjaminHalko
Copy link
Member Author

@oSumAtrIX done

@BenjaminHalko BenjaminHalko merged commit 0964f15 into ReVanced:compose-dev Sep 26, 2023
1 check passed
@BenjaminHalko BenjaminHalko deleted the compose-build-docs branch September 26, 2023 23:54
@oSumAtrIX oSumAtrIX removed a link to an issue Jul 25, 2024
docs: Update the docs to match the latest changes #1234
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oSumAtrIX oSumAtrIX oSumAtrIX approved these changes

Assignees
No one assigned
Labels
ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenjaminHalko @oSumAtrIX