feat(youtube/hide-autoplay-button): do not disable autoplay button wh…

…en hidden Signed-off-by: oSumAtrIX <johan.melkonyan1@web.de>
ReVanced · Mar 14, 2023 · 98d0084 · 98d0084
1 parent 7680838
commit 98d0084
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 58 deletions.
diff --git a/...vanced/patches/youtube/layout/buttons/autoplay/fingerprints/AutoNavInformerFingerprint.kt b/...vanced/patches/youtube/layout/buttons/autoplay/fingerprints/AutoNavInformerFingerprint.kt
diff --git a/...lin/app/revanced/patches/youtube/layout/buttons/autoplay/patch/HideAutoplayButtonPatch.kt b/...lin/app/revanced/patches/youtube/layout/buttons/autoplay/patch/HideAutoplayButtonPatch.kt
@@ -1,5 +1,6 @@
 package app.revanced.patches.youtube.layout.buttons.autoplay.patch
 
+import app.revanced.extensions.toErrorResult
 import app.revanced.patcher.annotation.Description
 import app.revanced.patcher.annotation.Name
 import app.revanced.patcher.annotation.Version
@@ -15,7 +16,6 @@ import app.revanced.patches.shared.mapping.misc.patch.ResourceMappingPatch
 import app.revanced.patches.shared.settings.preference.impl.StringResource
 import app.revanced.patches.shared.settings.preference.impl.SwitchPreference
 import app.revanced.patches.youtube.layout.buttons.autoplay.annotations.AutoplayButtonCompatibility
-import app.revanced.patches.youtube.layout.buttons.autoplay.fingerprints.AutoNavInformerFingerprint
 import app.revanced.patches.youtube.layout.buttons.autoplay.fingerprints.LayoutConstructorFingerprint
 import app.revanced.patches.youtube.misc.integrations.patch.IntegrationsPatch
 import app.revanced.patches.youtube.misc.settings.bytecode.patch.SettingsPatch
@@ -31,9 +31,7 @@ import org.jf.dexlib2.iface.reference.MethodReference
 @AutoplayButtonCompatibility
 @Version("0.0.1")
 class HideAutoplayButtonPatch : BytecodePatch(
-    listOf(
-        LayoutConstructorFingerprint, AutoNavInformerFingerprint
-    )
+    listOf(LayoutConstructorFingerprint)
 ) {
     override fun execute(context: BytecodeContext): PatchResult {
         SettingsPatch.PreferenceScreen.LAYOUT.addPreferences(
@@ -43,49 +41,40 @@ class HideAutoplayButtonPatch : BytecodePatch(
                 true,
                 StringResource("revanced_hide_autoplay_button_summary_on", "Autoplay button is hidden"),
                 StringResource("revanced_hide_autoplay_button_summary_off", "Autoplay button is shown")
-            )
+            ),
         )
 
-        val autoNavInformerMethod = AutoNavInformerFingerprint.result!!.mutableMethod
+        LayoutConstructorFingerprint.result?.mutableMethod?.apply {
+            val layoutGenMethodInstructions = implementation!!.instructions
+
+            // resolve the offsets such as ...
+            val autoNavPreviewStubId = ResourceMappingPatch.resourceMappings.single {
+                it.name == "autonav_preview_stub"
+            }.id
 
-        val layoutGenMethodResult = LayoutConstructorFingerprint.result!!
-        val layoutGenMethod = layoutGenMethodResult.mutableMethod
-        val layoutGenMethodInstructions = layoutGenMethod.implementation!!.instructions
+            // where to insert the branch instructions and ...
+            val insertIndex = layoutGenMethodInstructions.indexOfFirst {
+                (it as? WideLiteralInstruction)?.wideLiteral == autoNavPreviewStubId
+            }
 
-        // resolve the offsets such as ...
-        val autoNavPreviewStubId = ResourceMappingPatch.resourceMappings.single {
-            it.name == "autonav_preview_stub"
-        }.id
-        // where to insert the branch instructions and ...
-        val insertIndex = layoutGenMethodInstructions.indexOfFirst {
-            (it as? WideLiteralInstruction)?.wideLiteral == autoNavPreviewStubId
-        }
-        // where to branch away
-        val branchIndex = layoutGenMethodInstructions.subList(insertIndex + 1, layoutGenMethodInstructions.size - 1).indexOfFirst {
-            ((it as? ReferenceInstruction)?.reference as? MethodReference)?.name == "addOnLayoutChangeListener"
-        } + 2
+            // where to branch away
+            val branchIndex =
+                layoutGenMethodInstructions.subList(insertIndex + 1, layoutGenMethodInstructions.size - 1)
+                    .indexOfFirst {
+                        ((it as? ReferenceInstruction)?.reference as? MethodReference)?.name == "addOnLayoutChangeListener"
+                    } + 2
 
-        val jumpInstruction = layoutGenMethodInstructions[insertIndex + branchIndex] as Instruction
-        layoutGenMethod.addInstructions(
-            insertIndex, """
+            val jumpInstruction = layoutGenMethodInstructions[insertIndex + branchIndex] as Instruction
+
+            addInstructions(
+                insertIndex,
+                """
                 invoke-static {}, Lapp/revanced/integrations/patches/HideAutoplayButtonPatch;->isButtonShown()Z
                 move-result v11
                 if-eqz v11, :hidden
             """, listOf(ExternalLabel("hidden", jumpInstruction))
-        )
-
-        //force disable autoplay since it's hard to do without the button
-        autoNavInformerMethod.addInstructions(
-            0, """
-            invoke-static {}, Lapp/revanced/integrations/patches/HideAutoplayButtonPatch;->isButtonShown()Z
-            move-result v0
-            if-nez v0, :hidden
-            const/4 v0, 0x0
-            return v0
-            :hidden
-            nop
-        """
-        )
+            )
+        } ?: return LayoutConstructorFingerprint.toErrorResult()
 
         return PatchResultSuccess()
     }