-
-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(YouTube - Miniplayer): Rename Tablet mini player
and allow selecting the style of the in-app miniplayer
#3302
feat(YouTube - Miniplayer): Rename Tablet mini player
and allow selecting the style of the in-app miniplayer
#3302
Conversation
08684be
to
0576089
Compare
What about ModernMiniPlayerConfigFingerprint.kt here https://github.com/inotia00/revanced-patches/tree/revanced-extended/src/main/kotlin/app/revanced/patches/youtube/general/tabletminiplayer Is it necessary for Tablet Mini player or it's a different thing? |
That adds a toggle for a different style mini player, but I suppose this PR could also add the feature |
…bletLayout` and `Tablet mini player` into a single patch
2eda3d3
to
907f239
Compare
There is also a new phone mini player, that is apparently being rolled out to some users but maybe everyone will get it. So there will be a chance to both use the new or force the old. With a bit more work, this PR should be able to pick which mini player type to use (old phone style, old tablet, modern phone, modern tablet). |
also
|
iirc, there were three Modern mini player types Depending on this value, different Modern mini players are applied If this value was 2 or 3, there would be issues with player controls or titles not displaying properly when minimized in vertical video, so I didn't include it in the patch ※ This is not important information, but this issue is not reproduced in Modern mini player |
Type 2 the sub title is clipped for both horizontal and vertical videos (it shows as the grey circle on the lower left of the pip). With vertical videos the play button is clipped slightly, probably because it was intended for a tablet and the device sizing is now off: Except for the missing skip buttons with vertical videos, type 3 seems to work correctly for all the videos I tried: In the hooked code there are checks for a type 4, but using it gives a half broken layout similar to type 2 (maybe it's work in progress or remnants of an abandoned design). |
Tablet mini player
and allow selecting which style in app mini player to use
Tablet mini player
and allow selecting which style in app mini player to useTablet mini player
and allow selecting which style in-app mini player to use
src/main/kotlin/app/revanced/util/patch/LiteralValueFingerprint.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/youtube/layout/miniplayer/MiniplayerPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/youtube/layout/miniplayer/MiniplayerPatch.kt
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/youtube/layout/miniplayer/MiniplayerPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/youtube/layout/miniplayer/MiniplayerPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/youtube/layout/miniplayer/MiniplayerPatch.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: oSumAtrIX <johan.melkonyan1@web.de>
Co-authored-by: oSumAtrIX <johan.melkonyan1@web.de>
…/MiniplayerPatch.kt Co-authored-by: oSumAtrIX <johan.melkonyan1@web.de>
…/MiniplayerPatch.kt Co-authored-by: oSumAtrIX <johan.melkonyan1@web.de>
…/MiniplayerResourcePatch.kt Co-authored-by: oSumAtrIX <johan.melkonyan1@web.de>
…/MiniplayerPatch.kt Co-authored-by: oSumAtrIX <johan.melkonyan1@web.de>
…/MiniplayerPatch.kt Co-authored-by: oSumAtrIX <johan.melkonyan1@web.de>
…/MiniplayerPatch.kt Co-authored-by: oSumAtrIX <johan.melkonyan1@web.de>
…/MiniplayerPatch.kt Co-authored-by: oSumAtrIX <johan.melkonyan1@web.de>
…/MiniplayerPatch.kt Co-authored-by: oSumAtrIX <johan.melkonyan1@web.de>
…/MiniplayerPatch.kt Co-authored-by: oSumAtrIX <johan.melkonyan1@web.de>
src/main/kotlin/app/revanced/patches/youtube/layout/miniplayer/MiniplayerPatch.kt
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/youtube/layout/miniplayer/MiniplayerPatch.kt
Outdated
Show resolved
Hide resolved
…/MiniplayerPatch.kt
# [4.10.0-dev.1](v4.9.0...v4.10.0-dev.1) (2024-06-07) ### Features * **YouTube - Miniplayer:** Rename `Tablet mini player` and allow selecting the style of the in-app miniplayer ([#3302](#3302)) ([5511736](5511736))
# [4.10.0-dev.1](v4.9.0...v4.10.0-dev.1) (2024-06-13) ### Bug Fixes * **YouTube - Client spoof:** Correctly play more livestreams using Android VR ([ReVanced#3316](https://github.com/1fexd/revanced-patches-contrib/issues/3316)) ([c05264a](c05264a)) * **YouTube Music:** Rename `Minimized playback` to `Remove background playback restrictions` ([ReVanced#3315](https://github.com/1fexd/revanced-patches-contrib/issues/3315)) ([3c31e55](3c31e55)) * **YouTube:** Rename `Minimized playback` to `Remove background playback restrictions` ([ReVanced#3314](https://github.com/1fexd/revanced-patches-contrib/issues/3314)) ([37d415b](37d415b)) ### Features * Add allow app downgrading patch ([4f20cc9](4f20cc9)) * **Boost For Reddit:** Add `Fix /s/ links` patch ([ReVanced#3154](https://github.com/1fexd/revanced-patches-contrib/issues/3154)) ([5fa9fd2](5fa9fd2)) * **Boost for Reddit:** Add `Fix audio missing in video downloads` patch ([ReVanced#3287](https://github.com/1fexd/revanced-patches-contrib/issues/3287)) ([a9258d4](a9258d4)) * **YouTube - Comments:** Add `Hide Thanks button` and `Hide 'Comments by members' header` options ([ReVanced#3317](https://github.com/1fexd/revanced-patches-contrib/issues/3317)) ([9c4c4f0](9c4c4f0)) * **YouTube - Miniplayer:** Rename `Tablet mini player` and allow selecting the style of the in-app miniplayer ([ReVanced#3302](https://github.com/1fexd/revanced-patches-contrib/issues/3302)) ([5511736](5511736))
# [4.10.0](v4.9.0...v4.10.0) (2024-06-13) ### Bug Fixes * **YouTube - Client spoof:** Correctly play more livestreams using Android VR ([ReVanced#3316](https://github.com/1fexd/revanced-patches-contrib/issues/3316)) ([c05264a](c05264a)) * **YouTube Music:** Rename `Minimized playback` to `Remove background playback restrictions` ([ReVanced#3315](https://github.com/1fexd/revanced-patches-contrib/issues/3315)) ([3c31e55](3c31e55)) * **YouTube:** Rename `Minimized playback` to `Remove background playback restrictions` ([ReVanced#3314](https://github.com/1fexd/revanced-patches-contrib/issues/3314)) ([37d415b](37d415b)) ### Features * Add allow app downgrading patch ([4f20cc9](4f20cc9)) * **Boost For Reddit:** Add `Fix /s/ links` patch ([ReVanced#3154](https://github.com/1fexd/revanced-patches-contrib/issues/3154)) ([5fa9fd2](5fa9fd2)) * **Boost for Reddit:** Add `Fix audio missing in video downloads` patch ([ReVanced#3287](https://github.com/1fexd/revanced-patches-contrib/issues/3287)) ([a9258d4](a9258d4)) * **YouTube - Comments:** Add `Hide Thanks button` and `Hide 'Comments by members' header` options ([ReVanced#3317](https://github.com/1fexd/revanced-patches-contrib/issues/3317)) ([9c4c4f0](9c4c4f0)) * **YouTube - Miniplayer:** Rename `Tablet mini player` and allow selecting the style of the in-app miniplayer ([ReVanced#3302](https://github.com/1fexd/revanced-patches-contrib/issues/3302)) ([5511736](5511736))
# [4.10.0](v4.9.0...v4.10.0) (2024-06-23) ### Bug Fixes * Correct invalid string name ([b84494f](b84494f)) * **YouTube - Client spoof:** Correctly play more livestreams using Android VR ([#3316](#3316)) ([c05264a](c05264a)) * **YouTube - Hide description components:** Replace `Hide game section` and `Hide music section` with `Hide attributes section` ([#3327](#3327)) ([0198a43](0198a43)) * **YouTube Music:** Rename `Minimized playback` to `Remove background playback restrictions` ([#3315](#3315)) ([3c31e55](3c31e55)) * **YouTube:** Rename `Minimized playback` to `Remove background playback restrictions` ([#3314](#3314)) ([37d415b](37d415b)) ### Features * Add `Change version code` patch ([#3338](#3338)) ([685ef39](685ef39)) * **Boost For Reddit:** Add `Fix /s/ links` patch ([#3154](#3154)) ([5fa9fd2](5fa9fd2)) * **Boost for Reddit:** Add `Fix audio missing in video downloads` patch ([#3287](#3287)) ([a9258d4](a9258d4)) * **YouTube - Comments:** Add `Hide 'Create a Short' button` option ([#3333](#3333)) ([be9e244](be9e244)) * **YouTube - Comments:** Add `Hide Thanks button` and `Hide 'Comments by members' header` options ([#3317](#3317)) ([9c4c4f0](9c4c4f0)) * **YouTube - Miniplayer:** Rename `Tablet mini player` and allow selecting the style of the in-app miniplayer ([#3302](#3302)) ([5511736](5511736))
# [4.10.0](v4.9.0...v4.10.0) (2024-06-23) ### Bug Fixes * Correct invalid string name ([b84494f](b84494f)) * **YouTube - Client spoof:** Correctly play more livestreams using Android VR ([ReVanced#3316](https://github.com/E85Addict/revanced-patches/issues/3316)) ([c05264a](c05264a)) * **YouTube - Hide description components:** Replace `Hide game section` and `Hide music section` with `Hide attributes section` ([ReVanced#3327](https://github.com/E85Addict/revanced-patches/issues/3327)) ([0198a43](0198a43)) * **YouTube Music:** Rename `Minimized playback` to `Remove background playback restrictions` ([ReVanced#3315](https://github.com/E85Addict/revanced-patches/issues/3315)) ([3c31e55](3c31e55)) * **YouTube:** Rename `Minimized playback` to `Remove background playback restrictions` ([ReVanced#3314](https://github.com/E85Addict/revanced-patches/issues/3314)) ([37d415b](37d415b)) ### Features * Add `Change version code` patch ([ReVanced#3338](https://github.com/E85Addict/revanced-patches/issues/3338)) ([685ef39](685ef39)) * **Boost For Reddit:** Add `Fix /s/ links` patch ([ReVanced#3154](https://github.com/E85Addict/revanced-patches/issues/3154)) ([5fa9fd2](5fa9fd2)) * **Boost for Reddit:** Add `Fix audio missing in video downloads` patch ([ReVanced#3287](https://github.com/E85Addict/revanced-patches/issues/3287)) ([a9258d4](a9258d4)) * **YouTube - Comments:** Add `Hide 'Create a Short' button` option ([ReVanced#3333](https://github.com/E85Addict/revanced-patches/issues/3333)) ([be9e244](be9e244)) * **YouTube - Comments:** Add `Hide Thanks button` and `Hide 'Comments by members' header` options ([ReVanced#3317](https://github.com/E85Addict/revanced-patches/issues/3317)) ([9c4c4f0](9c4c4f0)) * **YouTube - Miniplayer:** Rename `Tablet mini player` and allow selecting the style of the in-app miniplayer ([ReVanced#3302](https://github.com/E85Addict/revanced-patches/issues/3302)) ([5511736](5511736)) ### Performance Improvements * Personal Logo && Add upstream sync ([5a86c70](5a86c70))
# [4.10.0](v4.9.0...v4.10.0) (2024-07-07) ### Bug Fixes * Correct invalid string name ([b84494f](b84494f)) * **YouTube - Client spoof:** Correctly play more livestreams using Android VR ([ReVanced#3316](https://github.com/E85Addict/revanced-patches/issues/3316)) ([c05264a](c05264a)) * **YouTube - Hide description components:** Replace `Hide game section` and `Hide music section` with `Hide attributes section` ([ReVanced#3327](https://github.com/E85Addict/revanced-patches/issues/3327)) ([0198a43](0198a43)) * **YouTube Music:** Rename `Minimized playback` to `Remove background playback restrictions` ([ReVanced#3315](https://github.com/E85Addict/revanced-patches/issues/3315)) ([3c31e55](3c31e55)) * **YouTube:** Rename `Minimized playback` to `Remove background playback restrictions` ([ReVanced#3314](https://github.com/E85Addict/revanced-patches/issues/3314)) ([37d415b](37d415b)) ### Features * Add `Change version code` patch ([ReVanced#3338](https://github.com/E85Addict/revanced-patches/issues/3338)) ([685ef39](685ef39)) * **Boost For Reddit:** Add `Fix /s/ links` patch ([ReVanced#3154](https://github.com/E85Addict/revanced-patches/issues/3154)) ([5fa9fd2](5fa9fd2)) * **Boost for Reddit:** Add `Fix audio missing in video downloads` patch ([ReVanced#3287](https://github.com/E85Addict/revanced-patches/issues/3287)) ([a9258d4](a9258d4)) * **YouTube - Comments:** Add `Hide 'Create a Short' button` option ([ReVanced#3333](https://github.com/E85Addict/revanced-patches/issues/3333)) ([be9e244](be9e244)) * **YouTube - Comments:** Add `Hide Thanks button` and `Hide 'Comments by members' header` options ([ReVanced#3317](https://github.com/E85Addict/revanced-patches/issues/3317)) ([9c4c4f0](9c4c4f0)) * **YouTube - Miniplayer:** Rename `Tablet mini player` and allow selecting the style of the in-app miniplayer ([ReVanced#3302](https://github.com/E85Addict/revanced-patches/issues/3302)) ([5511736](5511736)) ### Performance Improvements * Personal Logo && Add upstream sync ([fc5b72d](fc5b72d))
# [4.10.0](v4.9.0...v4.10.0) (2024-07-11) ### Bug Fixes * Correct invalid string name ([b84494f](b84494f)) * **YouTube - Client spoof:** Correctly play more livestreams using Android VR ([ReVanced#3316](https://github.com/E85Addict/revanced-patches/issues/3316)) ([c05264a](c05264a)) * **YouTube - Hide description components:** Replace `Hide game section` and `Hide music section` with `Hide attributes section` ([ReVanced#3327](https://github.com/E85Addict/revanced-patches/issues/3327)) ([0198a43](0198a43)) * **YouTube Music:** Rename `Minimized playback` to `Remove background playback restrictions` ([ReVanced#3315](https://github.com/E85Addict/revanced-patches/issues/3315)) ([3c31e55](3c31e55)) * **YouTube:** Rename `Minimized playback` to `Remove background playback restrictions` ([ReVanced#3314](https://github.com/E85Addict/revanced-patches/issues/3314)) ([37d415b](37d415b)) ### Features * Add `Change version code` patch ([ReVanced#3338](https://github.com/E85Addict/revanced-patches/issues/3338)) ([685ef39](685ef39)) * **Boost For Reddit:** Add `Fix /s/ links` patch ([ReVanced#3154](https://github.com/E85Addict/revanced-patches/issues/3154)) ([5fa9fd2](5fa9fd2)) * **Boost for Reddit:** Add `Fix audio missing in video downloads` patch ([ReVanced#3287](https://github.com/E85Addict/revanced-patches/issues/3287)) ([a9258d4](a9258d4)) * **YouTube - Comments:** Add `Hide 'Create a Short' button` option ([ReVanced#3333](https://github.com/E85Addict/revanced-patches/issues/3333)) ([be9e244](be9e244)) * **YouTube - Comments:** Add `Hide Thanks button` and `Hide 'Comments by members' header` options ([ReVanced#3317](https://github.com/E85Addict/revanced-patches/issues/3317)) ([9c4c4f0](9c4c4f0)) * **YouTube - Miniplayer:** Rename `Tablet mini player` and allow selecting the style of the in-app miniplayer ([ReVanced#3302](https://github.com/E85Addict/revanced-patches/issues/3302)) ([5511736](5511736)) ### Performance Improvements * Personal Logo && Add upstream sync ([05677c9](05677c9))
Changes made:
Also fixes a
Spoof client
fingerprint needed for 18.x support.Integration changes
Phone miniplayer
Tablet miniplayer
Modern miniplayer 1
Modern miniplayer 2
Modern miniplayer 3