Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTube - Miniplayer): Rename Tablet mini player and allow selecting the style of the in-app miniplayer #3302

Merged

Conversation

LisoUseInAIKyrios
Copy link
Contributor

@LisoUseInAIKyrios LisoUseInAIKyrios commented Jun 4, 2024

Changes made:

Also fixes a Spoof client fingerprint needed for 18.x support.

Integration changes

Phone miniplayer

Phone miniplayer

Tablet miniplayer

Tablet

Modern miniplayer 1

Modern type 1

Modern miniplayer 2

Modern type 2

Modern miniplayer 3

Modern type 3

@kazimmt
Copy link
Contributor

kazimmt commented Jun 4, 2024

What about ModernMiniPlayerConfigFingerprint.kt here https://github.com/inotia00/revanced-patches/tree/revanced-extended/src/main/kotlin/app/revanced/patches/youtube/general/tabletminiplayer

Is it necessary for Tablet Mini player or it's a different thing?

@LisoUseInAIKyrios
Copy link
Contributor Author

That adds a toggle for a different style mini player, but I suppose this PR could also add the feature

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title fix(YouTube - Tablet mini player): Correctly show mini player buttons feat(YouTube - Tablet layout): Modern tablet mini player Jun 4, 2024
@LisoUseInAIKyrios LisoUseInAIKyrios marked this pull request as draft June 4, 2024 18:13
@LisoUseInAIKyrios LisoUseInAIKyrios marked this pull request as draft June 4, 2024 18:13
@LisoUseInAIKyrios
Copy link
Contributor Author

There is also a new phone mini player, that is apparently being rolled out to some users but maybe everyone will get it. So there will be a chance to both use the new or force the old.

With a bit more work, this PR should be able to pick which mini player type to use (old phone style, old tablet, modern phone, modern tablet).

New phone mini player

@kazimmt
Copy link
Contributor

kazimmt commented Jun 4, 2024

Screenshot_20240605-021008_YouTube
Close button working as going full view
Full view button working as closing the mini player

@MarcaDian
Copy link
Contributor

MarcaDian commented Jun 4, 2024

Close button working as going full view
Full view button working as closing the mini player

https://github.com/inotia00/revanced-patches/blob/a71ce6b88cceb135492e10f6e7a20f7157e9133d/src/main/kotlin/app/revanced/patches/youtube/general/tabletminiplayer/TabletMiniPlayerPatch.kt#L84

also

This issue has been fixed in YouTube 19.17.41+.

@inotia00
Copy link

inotia00 commented Jun 5, 2024

There is also a new phone mini player, that is apparently being rolled out to some users but maybe everyone will get it. So there will be a chance to both use the new or force the old.

iirc, there were three Modern mini player types

Depending on this value, different Modern mini players are applied
(Available values ​​are 1, 2, 3)

If this value was 2 or 3, there would be issues with player controls or titles not displaying properly when minimized in vertical video, so I didn't include it in the patch

※ This is not important information, but this issue is not reproduced in Modern mini player

@LisoUseInAIKyrios
Copy link
Contributor Author

LisoUseInAIKyrios commented Jun 5, 2024

Type 2 the sub title is clipped for both horizontal and vertical videos (it shows as the grey circle on the lower left of the pip). With vertical videos the play button is clipped slightly, probably because it was intended for a tablet and the device sizing is now off:

Type 2
Type 2

Except for the missing skip buttons with vertical videos, type 3 seems to work correctly for all the videos I tried:

Type 3
Type 3

In the hooked code there are checks for a type 4, but using it gives a half broken layout similar to type 2 (maybe it's work in progress or remnants of an abandoned design).

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title feat(YouTube - Tablet layout): Modern tablet mini player feat(YouTube - Mini player): Rename Tablet mini player and allow selecting which style in app mini player to use Jun 5, 2024
@LisoUseInAIKyrios LisoUseInAIKyrios changed the title feat(YouTube - Mini player): Rename Tablet mini player and allow selecting which style in app mini player to use feat(YouTube - Mini player): Rename Tablet mini player and allow selecting which style in-app mini player to use Jun 5, 2024
@LisoUseInAIKyrios LisoUseInAIKyrios marked this pull request as ready for review June 5, 2024 17:15
LisoUseInAIKyrios and others added 17 commits June 8, 2024 00:31
Co-authored-by: oSumAtrIX <johan.melkonyan1@web.de>
Co-authored-by: oSumAtrIX <johan.melkonyan1@web.de>
…/MiniplayerPatch.kt

Co-authored-by: oSumAtrIX <johan.melkonyan1@web.de>
…/MiniplayerPatch.kt

Co-authored-by: oSumAtrIX <johan.melkonyan1@web.de>
…/MiniplayerResourcePatch.kt

Co-authored-by: oSumAtrIX <johan.melkonyan1@web.de>
…/MiniplayerPatch.kt

Co-authored-by: oSumAtrIX <johan.melkonyan1@web.de>
…/MiniplayerPatch.kt

Co-authored-by: oSumAtrIX <johan.melkonyan1@web.de>
…/MiniplayerPatch.kt

Co-authored-by: oSumAtrIX <johan.melkonyan1@web.de>
…/MiniplayerPatch.kt

Co-authored-by: oSumAtrIX <johan.melkonyan1@web.de>
…/MiniplayerPatch.kt

Co-authored-by: oSumAtrIX <johan.melkonyan1@web.de>
…/MiniplayerPatch.kt

Co-authored-by: oSumAtrIX <johan.melkonyan1@web.de>
@LisoUseInAIKyrios LisoUseInAIKyrios merged commit 5511736 into ReVanced:dev Jun 7, 2024
2 checks passed
@LisoUseInAIKyrios LisoUseInAIKyrios deleted the fix_tablet_miniplayer branch June 7, 2024 22:48
revanced-bot pushed a commit that referenced this pull request Jun 7, 2024
# [4.10.0-dev.1](v4.9.0...v4.10.0-dev.1) (2024-06-07)

### Features

* **YouTube - Miniplayer:** Rename `Tablet mini player` and allow selecting the style of the in-app miniplayer ([#3302](#3302)) ([5511736](5511736))
1fexd pushed a commit to 1fexd/revanced-patches-contrib that referenced this pull request Jun 13, 2024
# [4.10.0-dev.1](v4.9.0...v4.10.0-dev.1) (2024-06-13)

### Bug Fixes

* **YouTube - Client spoof:** Correctly play more livestreams using Android VR ([ReVanced#3316](https://github.com/1fexd/revanced-patches-contrib/issues/3316)) ([c05264a](c05264a))
* **YouTube Music:** Rename `Minimized playback` to `Remove background playback restrictions` ([ReVanced#3315](https://github.com/1fexd/revanced-patches-contrib/issues/3315)) ([3c31e55](3c31e55))
* **YouTube:** Rename `Minimized playback` to `Remove background playback restrictions` ([ReVanced#3314](https://github.com/1fexd/revanced-patches-contrib/issues/3314)) ([37d415b](37d415b))

### Features

* Add allow app downgrading patch ([4f20cc9](4f20cc9))
* **Boost For Reddit:** Add `Fix /s/ links` patch ([ReVanced#3154](https://github.com/1fexd/revanced-patches-contrib/issues/3154)) ([5fa9fd2](5fa9fd2))
* **Boost for Reddit:** Add `Fix audio missing in video downloads` patch ([ReVanced#3287](https://github.com/1fexd/revanced-patches-contrib/issues/3287)) ([a9258d4](a9258d4))
* **YouTube - Comments:** Add `Hide Thanks button` and `Hide 'Comments by members' header` options ([ReVanced#3317](https://github.com/1fexd/revanced-patches-contrib/issues/3317)) ([9c4c4f0](9c4c4f0))
* **YouTube - Miniplayer:** Rename `Tablet mini player` and allow selecting the style of the in-app miniplayer ([ReVanced#3302](https://github.com/1fexd/revanced-patches-contrib/issues/3302)) ([5511736](5511736))
1fexd pushed a commit to 1fexd/revanced-patches-contrib that referenced this pull request Jun 13, 2024
# [4.10.0](v4.9.0...v4.10.0) (2024-06-13)

### Bug Fixes

* **YouTube - Client spoof:** Correctly play more livestreams using Android VR ([ReVanced#3316](https://github.com/1fexd/revanced-patches-contrib/issues/3316)) ([c05264a](c05264a))
* **YouTube Music:** Rename `Minimized playback` to `Remove background playback restrictions` ([ReVanced#3315](https://github.com/1fexd/revanced-patches-contrib/issues/3315)) ([3c31e55](3c31e55))
* **YouTube:** Rename `Minimized playback` to `Remove background playback restrictions` ([ReVanced#3314](https://github.com/1fexd/revanced-patches-contrib/issues/3314)) ([37d415b](37d415b))

### Features

* Add allow app downgrading patch ([4f20cc9](4f20cc9))
* **Boost For Reddit:** Add `Fix /s/ links` patch ([ReVanced#3154](https://github.com/1fexd/revanced-patches-contrib/issues/3154)) ([5fa9fd2](5fa9fd2))
* **Boost for Reddit:** Add `Fix audio missing in video downloads` patch ([ReVanced#3287](https://github.com/1fexd/revanced-patches-contrib/issues/3287)) ([a9258d4](a9258d4))
* **YouTube - Comments:** Add `Hide Thanks button` and `Hide 'Comments by members' header` options ([ReVanced#3317](https://github.com/1fexd/revanced-patches-contrib/issues/3317)) ([9c4c4f0](9c4c4f0))
* **YouTube - Miniplayer:** Rename `Tablet mini player` and allow selecting the style of the in-app miniplayer ([ReVanced#3302](https://github.com/1fexd/revanced-patches-contrib/issues/3302)) ([5511736](5511736))
revanced-bot pushed a commit that referenced this pull request Jun 23, 2024
# [4.10.0](v4.9.0...v4.10.0) (2024-06-23)

### Bug Fixes

* Correct invalid string name ([b84494f](b84494f))
* **YouTube - Client spoof:** Correctly play more livestreams using Android VR ([#3316](#3316)) ([c05264a](c05264a))
* **YouTube - Hide description components:** Replace `Hide game section` and `Hide music section` with `Hide attributes section` ([#3327](#3327)) ([0198a43](0198a43))
* **YouTube Music:** Rename `Minimized playback` to `Remove background playback restrictions` ([#3315](#3315)) ([3c31e55](3c31e55))
* **YouTube:** Rename `Minimized playback` to `Remove background playback restrictions` ([#3314](#3314)) ([37d415b](37d415b))

### Features

* Add `Change version code` patch ([#3338](#3338)) ([685ef39](685ef39))
* **Boost For Reddit:** Add `Fix /s/ links` patch ([#3154](#3154)) ([5fa9fd2](5fa9fd2))
* **Boost for Reddit:** Add `Fix audio missing in video downloads` patch ([#3287](#3287)) ([a9258d4](a9258d4))
* **YouTube - Comments:** Add `Hide 'Create a Short' button` option ([#3333](#3333)) ([be9e244](be9e244))
* **YouTube - Comments:** Add `Hide Thanks button` and `Hide 'Comments by members' header` options ([#3317](#3317)) ([9c4c4f0](9c4c4f0))
* **YouTube - Miniplayer:** Rename `Tablet mini player` and allow selecting the style of the in-app miniplayer ([#3302](#3302)) ([5511736](5511736))
E85Addict pushed a commit to E85Addict/revanced-patches that referenced this pull request Jun 23, 2024
# [4.10.0](v4.9.0...v4.10.0) (2024-06-23)

### Bug Fixes

* Correct invalid string name ([b84494f](b84494f))
* **YouTube - Client spoof:** Correctly play more livestreams using Android VR ([ReVanced#3316](https://github.com/E85Addict/revanced-patches/issues/3316)) ([c05264a](c05264a))
* **YouTube - Hide description components:** Replace `Hide game section` and `Hide music section` with `Hide attributes section` ([ReVanced#3327](https://github.com/E85Addict/revanced-patches/issues/3327)) ([0198a43](0198a43))
* **YouTube Music:** Rename `Minimized playback` to `Remove background playback restrictions` ([ReVanced#3315](https://github.com/E85Addict/revanced-patches/issues/3315)) ([3c31e55](3c31e55))
* **YouTube:** Rename `Minimized playback` to `Remove background playback restrictions` ([ReVanced#3314](https://github.com/E85Addict/revanced-patches/issues/3314)) ([37d415b](37d415b))

### Features

* Add `Change version code` patch ([ReVanced#3338](https://github.com/E85Addict/revanced-patches/issues/3338)) ([685ef39](685ef39))
* **Boost For Reddit:** Add `Fix /s/ links` patch ([ReVanced#3154](https://github.com/E85Addict/revanced-patches/issues/3154)) ([5fa9fd2](5fa9fd2))
* **Boost for Reddit:** Add `Fix audio missing in video downloads` patch ([ReVanced#3287](https://github.com/E85Addict/revanced-patches/issues/3287)) ([a9258d4](a9258d4))
* **YouTube - Comments:** Add `Hide 'Create a Short' button` option ([ReVanced#3333](https://github.com/E85Addict/revanced-patches/issues/3333)) ([be9e244](be9e244))
* **YouTube - Comments:** Add `Hide Thanks button` and `Hide 'Comments by members' header` options ([ReVanced#3317](https://github.com/E85Addict/revanced-patches/issues/3317)) ([9c4c4f0](9c4c4f0))
* **YouTube - Miniplayer:** Rename `Tablet mini player` and allow selecting the style of the in-app miniplayer ([ReVanced#3302](https://github.com/E85Addict/revanced-patches/issues/3302)) ([5511736](5511736))

### Performance Improvements

* Personal Logo && Add upstream sync ([5a86c70](5a86c70))
E85Addict pushed a commit to E85Addict/revanced-patches that referenced this pull request Jul 7, 2024
# [4.10.0](v4.9.0...v4.10.0) (2024-07-07)

### Bug Fixes

* Correct invalid string name ([b84494f](b84494f))
* **YouTube - Client spoof:** Correctly play more livestreams using Android VR ([ReVanced#3316](https://github.com/E85Addict/revanced-patches/issues/3316)) ([c05264a](c05264a))
* **YouTube - Hide description components:** Replace `Hide game section` and `Hide music section` with `Hide attributes section` ([ReVanced#3327](https://github.com/E85Addict/revanced-patches/issues/3327)) ([0198a43](0198a43))
* **YouTube Music:** Rename `Minimized playback` to `Remove background playback restrictions` ([ReVanced#3315](https://github.com/E85Addict/revanced-patches/issues/3315)) ([3c31e55](3c31e55))
* **YouTube:** Rename `Minimized playback` to `Remove background playback restrictions` ([ReVanced#3314](https://github.com/E85Addict/revanced-patches/issues/3314)) ([37d415b](37d415b))

### Features

* Add `Change version code` patch ([ReVanced#3338](https://github.com/E85Addict/revanced-patches/issues/3338)) ([685ef39](685ef39))
* **Boost For Reddit:** Add `Fix /s/ links` patch ([ReVanced#3154](https://github.com/E85Addict/revanced-patches/issues/3154)) ([5fa9fd2](5fa9fd2))
* **Boost for Reddit:** Add `Fix audio missing in video downloads` patch ([ReVanced#3287](https://github.com/E85Addict/revanced-patches/issues/3287)) ([a9258d4](a9258d4))
* **YouTube - Comments:** Add `Hide 'Create a Short' button` option ([ReVanced#3333](https://github.com/E85Addict/revanced-patches/issues/3333)) ([be9e244](be9e244))
* **YouTube - Comments:** Add `Hide Thanks button` and `Hide 'Comments by members' header` options ([ReVanced#3317](https://github.com/E85Addict/revanced-patches/issues/3317)) ([9c4c4f0](9c4c4f0))
* **YouTube - Miniplayer:** Rename `Tablet mini player` and allow selecting the style of the in-app miniplayer ([ReVanced#3302](https://github.com/E85Addict/revanced-patches/issues/3302)) ([5511736](5511736))

### Performance Improvements

* Personal Logo && Add upstream sync ([fc5b72d](fc5b72d))
E85Addict pushed a commit to E85Addict/revanced-patches that referenced this pull request Jul 11, 2024
# [4.10.0](v4.9.0...v4.10.0) (2024-07-11)

### Bug Fixes

* Correct invalid string name ([b84494f](b84494f))
* **YouTube - Client spoof:** Correctly play more livestreams using Android VR ([ReVanced#3316](https://github.com/E85Addict/revanced-patches/issues/3316)) ([c05264a](c05264a))
* **YouTube - Hide description components:** Replace `Hide game section` and `Hide music section` with `Hide attributes section` ([ReVanced#3327](https://github.com/E85Addict/revanced-patches/issues/3327)) ([0198a43](0198a43))
* **YouTube Music:** Rename `Minimized playback` to `Remove background playback restrictions` ([ReVanced#3315](https://github.com/E85Addict/revanced-patches/issues/3315)) ([3c31e55](3c31e55))
* **YouTube:** Rename `Minimized playback` to `Remove background playback restrictions` ([ReVanced#3314](https://github.com/E85Addict/revanced-patches/issues/3314)) ([37d415b](37d415b))

### Features

* Add `Change version code` patch ([ReVanced#3338](https://github.com/E85Addict/revanced-patches/issues/3338)) ([685ef39](685ef39))
* **Boost For Reddit:** Add `Fix /s/ links` patch ([ReVanced#3154](https://github.com/E85Addict/revanced-patches/issues/3154)) ([5fa9fd2](5fa9fd2))
* **Boost for Reddit:** Add `Fix audio missing in video downloads` patch ([ReVanced#3287](https://github.com/E85Addict/revanced-patches/issues/3287)) ([a9258d4](a9258d4))
* **YouTube - Comments:** Add `Hide 'Create a Short' button` option ([ReVanced#3333](https://github.com/E85Addict/revanced-patches/issues/3333)) ([be9e244](be9e244))
* **YouTube - Comments:** Add `Hide Thanks button` and `Hide 'Comments by members' header` options ([ReVanced#3317](https://github.com/E85Addict/revanced-patches/issues/3317)) ([9c4c4f0](9c4c4f0))
* **YouTube - Miniplayer:** Rename `Tablet mini player` and allow selecting the style of the in-app miniplayer ([ReVanced#3302](https://github.com/E85Addict/revanced-patches/issues/3302)) ([5511736](5511736))

### Performance Improvements

* Personal Logo && Add upstream sync ([05677c9](05677c9))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(YouTube - Tablet mini player): Mini player buttons are hidden / broken
5 participants