Skip to content

Conversation

nofishonfriday
Copy link
Contributor

@nofishonfriday nofishonfriday commented May 11, 2017

added Nanth_item Auto Gain staging... scripts from here to /Items Properties.

For these scripts to work it requires "spk77_Get max peak val and pos from take_function.lua" to be put in the same folder (also added in this commit).

I think spk's script should automatically be provided when installing these, but not show up.
So I added

@provides
[nomain] spk77_Get max peak val and pos from take_function.lua

in the scripts, and in spk's script

@NoIndex

Not sure if I did this correctly, someone please check. :)
Thanks.

edit:
Ok, I tried to fix the headers, but I'm stumped, sorry.

@cfillion
Copy link
Member

cfillion commented May 11, 2017

The header is fine now, but the same filename cannot be provided by two packages (when version differs, which version of the function file should be installed without risking breaking the other scripts that use it?).

You could provide a renamed copy of the file like this, without having to make two copies of it on the GitHub repo. The new name used when installing is specified after a > character in the provides line next to the original path:

Provides: [nomain] spk77_Get max peak val and pos from take_function.lua > Nantho_Item Auto-Gain Staging - Peak vs. RMS.lua/spk77_Get max peak val and pos from take_function.lua

The scripts's header could also use a nice About section and Link rather than the unused Instructions/Forum Thread/Extensions/License/etc.

@nofishonfriday
Copy link
Contributor Author

Thanks, phew build passed this time. 👯‍♂️
Hope it's fine now.

Re: header, this was done by the original script author this way so I refrained from modifying it originally.
But you're right, it makes sense adding these sections for better ReaPack useabilty. Done.


local info = debug.getinfo(1,'S');
script_path = info.source:match[[^@?(.*[\/])[^\/]-$]]
dofile(script_path .. "/spk77_Get max peak val and pos from take_function.lua")
Copy link
Member

@cfillion cfillion May 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be changed to use the new path to the file?

@@ -0,0 +1,169 @@
--[[
* Provides: [nomain] spk77_Get max peak val and pos from take_function.lua > Nantho_Item Auto-Gain Staging - Peak vs. RMS.lua/spk77_Get max peak val and pos from take_function_Copy2.lua
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could go in a "Peak vs. LUFS" folder to match the script's name, rather than both Copy1+Copy2 in one "RMS" directory (and then suffixing with CopyX is no longer necessary).

@nofishonfriday
Copy link
Contributor Author

nofishonfriday commented May 11, 2017

D'oh, you're right.
I'm closing this PR and open a new one when I tested in my own ReaPack repo it works properly.

@nofishonfriday
Copy link
Contributor Author

Hm..trying in my Reapack repo, the function script shows up in ReaPack browser despite the @NoIndex tag.
http://i.imgur.com/5tbPLaO.jpg

I'm out of wisdom.
Sorry to say, but I give up, this procedure is over my head (please don't take it as meant negative for ReaPack).

@cfillion
Copy link
Member

cfillion commented May 12, 2017

Sorry I didn't catch this before:

--[[
 * noindex
 * Version: 1.0
--]]

noindex like this alone isn't read as a tag by the indexer, but as a comment it should ignore.

To make it a tag it must have a value: NoIndex: true.
The @-syntax doesn't require a value – it assumes true if it's missing, so @noindex works too.

EDIT: Files having noindex enabled don't need to have a version tag since they're skipped altogether.

@nofishonfriday
Copy link
Contributor Author

Thanks for bearing with me. I'll try again. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants