-
Notifications
You must be signed in to change notification settings - Fork 169
added Nanth_item Auto Gain staging... #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The header is fine now, but the same filename cannot be provided by two packages (when version differs, which version of the function file should be installed without risking breaking the other scripts that use it?). You could provide a renamed copy of the file like this, without having to make two copies of it on the GitHub repo. The new name used when installing is specified after a
The scripts's header could also use a nice |
Thanks, phew build passed this time. 👯♂️ Re: header, this was done by the original script author this way so I refrained from modifying it originally. |
|
||
local info = debug.getinfo(1,'S'); | ||
script_path = info.source:match[[^@?(.*[\/])[^\/]-$]] | ||
dofile(script_path .. "/spk77_Get max peak val and pos from take_function.lua") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be changed to use the new path to the file?
@@ -0,0 +1,169 @@ | |||
--[[ | |||
* Provides: [nomain] spk77_Get max peak val and pos from take_function.lua > Nantho_Item Auto-Gain Staging - Peak vs. RMS.lua/spk77_Get max peak val and pos from take_function_Copy2.lua |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could go in a "Peak vs. LUFS" folder to match the script's name, rather than both Copy1+Copy2 in one "RMS" directory (and then suffixing with CopyX is no longer necessary).
D'oh, you're right. |
Hm..trying in my Reapack repo, the function script shows up in ReaPack browser despite the @NoIndex tag. I'm out of wisdom. |
Sorry I didn't catch this before:
To make it a tag it must have a value: EDIT: Files having noindex enabled don't need to have a version tag since they're skipped altogether. |
Thanks for bearing with me. I'll try again. :) |
added Nanth_item Auto Gain staging... scripts from here to /Items Properties.
For these scripts to work it requires "spk77_Get max peak val and pos from take_function.lua" to be put in the same folder (also added in this commit).
I think spk's script should automatically be provided when installing these, but not show up.
So I added
@provides
[nomain] spk77_Get max peak val and pos from take_function.lua
in the scripts, and in spk's script
@NoIndex
Not sure if I did this correctly, someone please check. :)
Thanks.
edit:
Ok, I tried to fix the headers, but I'm stumped, sorry.