Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will fix #37 by:
then()
/success()
/failure()
to not use the wrong onethen()
to promote Task type fromTask<P1, V1, E1>
toTask<P2, V2, E2>
(includingE1 -> E2
Error type change)For more information, please see MultipleErrorTypesTests.swift.
Caveat
If Task1 and Task2 have different Error types and
request2
fails,you will still receive
errorInfo
as non-nil, but nowerrorInfo!.error
will become asnil
.This is because there is no way to convert
request2
's error back to task1's Error type (which is required insuccess()
task-flow).To avoid this default behavior, it is user's job to add error-conversion logic to maintain same Error type throughout the task-flow, by adding another type-promotable
then()
/success()
/failure()
.