Skip to content

Don't show tooltip when render returns a falsy value #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2023
Merged

Don't show tooltip when render returns a falsy value #1019

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/components/TooltipController/TooltipController.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,17 +201,18 @@ const TooltipController = ({
}, [anchorRefs, providerActiveAnchor, activeAnchor, anchorId, anchorSelect])

/**
* content priority: children < renderContent or content < html
* content priority: children < render or content < html
* children should be lower priority so that it can be used as the "default" content
*/
let renderedContent: ChildrenType = children
const contentWrapperRef = useRef<HTMLDivElement>(null)
if (render) {
renderedContent = (
const rendered = render({ content: tooltipContent ?? null, activeAnchor }) as React.ReactNode
renderedContent = rendered ? (
<div ref={contentWrapperRef} className="react-tooltip-content-wrapper">
{render({ content: tooltipContent ?? null, activeAnchor }) as React.ReactNode}
{rendered}
</div>
)
) : null
} else if (tooltipContent) {
renderedContent = tooltipContent
}
Expand Down