feat(bodyMode-parentchain) #535 search parent chain for data-tip #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ass by sass feat #537
|
Thanks for your PR! Would you take a look at #530 and let me know how much it overlaps, and which might be preferable, for the build process? |
|
Hi Aron,
thanks for your input, I think I set up the pull requests wrong, it should only include the first commit #dba14c4.
Can you cherry pick this or do I have to resubmit a proper pull request ?
For the conversion from sass to node-sass I think the rollup setup goes further, so prefer #530 and reject mine.
Marco
Von: Aron Helser <notifications@github.com>
Gesendet: Donnerstag, 30. Januar 2020 15:19
An: wwayne/react-tooltip <react-tooltip@noreply.github.com>
Cc: METUS Dev <metus-dev@id-consult.com>; Author <author@noreply.github.com>
Betreff: Re: [wwayne/react-tooltip] feat(bodyMode-parentchain) #535 search parent chain for data-tip (#536)
Thanks for your PR! Would you take a look at #530<#530> and let me know how much it overlaps, and which might be preferable, for the build process?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#536>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALHZBSURTIR2SKSGBRVIDGLRALOWPANCNFSM4KHHVTNA>.
|
|
I will reissue on latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
walks the parent chain of the tooltip target to find a data-tip attribute.
It does not check if the mouse position is inside the parents bounding rect, so this only works if children are completely inside the client area of their parents.