feat: add borderClass prop to allow a custom border class #745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow overriding the default border class name "border" with a custom class name
| | delayHide | data-delay-hide | Number | | `<p data-tip="tooltip" data-delay-hide='1000'></p>` or `<ReactTooltip delayHide={1000} />` | | ||
| | delayShow | data-delay-show | Number | | `<p data-tip="tooltip" data-delay-show='1000'></p>` or `<ReactTooltip delayShow={1000} />` | | ||
| | delayUpdate | data-delay-update | Number | | `<p data-tip="tooltip" data-delay-update='1000'></p>` or `<ReactTooltip delayUpdate={1000} />` Sets a delay in calling getContent if the tooltip is already shown and you mouse over another target | | ||
| | insecure | null | Bool | true, false | Whether to inject the style header into the page dynamically (violates CSP style-src but is a convenient default) | | ||
| | border | data-border | Bool | true, false | Add one pixel white border | | ||
| | borderClass | data-border-class | String | e.g. custom-border-class | A custom class name to use for the border - enabled by the `border` prop | |
There was a problem hiding this comment.
All changes in this file besides this line were added automatically by the pre-commit hook
|
Hi @dannyharding10, can you update your PR with the master branch, please? I'll take a look at that one after it's updated with Master. Thanks! |
…into ReactTooltip-master
|
@danielbarion Updated! I think I did it right... |
|
Thank you @dannyharding10! That improvement will be released together in the next version, we will probably release that soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow overriding the default border class name "border" with a custom class name. Currently, when using a border it adds the class name "border", which is pretty generic and can be overridden by other styles (notably, bootstrap uses the class "border", overriding any
borderColorprovided to react-tooltip). This change makes it so that the user can provide a custom class name for the border class.