Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default Router export #2906

Merged
merged 1 commit into from
Jan 14, 2016
Merged

Remove default Router export #2906

merged 1 commit into from
Jan 14, 2016

Conversation

taion
Copy link
Contributor

@taion taion commented Jan 14, 2016

No description provided.

@timdorr
Copy link
Member

timdorr commented Jan 14, 2016

I'm similarly meh on this. It will break (trivially) some existing uses, but would be good to make it clear that you need more than just the default import.

@taion
Copy link
Contributor Author

taion commented Jan 14, 2016

You can't do anything useful if you're just using the default export anyway, since you'd (almost) always need <Route> anyway.

@timdorr
Copy link
Member

timdorr commented Jan 14, 2016

Yeah, that's why I'm only meh on this. The breakage isn't that big of a deal.

timdorr added a commit that referenced this pull request Jan 14, 2016
@timdorr timdorr merged commit 6bddfcc into remix-run:master Jan 14, 2016
@taion taion deleted the remove-default-export branch January 14, 2016 23:15
@ryanflorence
Copy link
Member

Just realized the best argument for this is when people do this:

import Link from 'react-router'

They render a bunch of routers all over the place and have no clue what is happening!

@ryanflorence
Copy link
Member

Also, can we get an entry in the CHANGES.md about this? Somebody somewhere is using it.

@taion taion mentioned this pull request Jan 16, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants