Skip to content

Conversation

annarankin
Copy link

Hello, folks!

This PR addresses Issue #2319. It allows Link components to render anchor tags without hrefs when the to prop is not specified.

Love to hear what you think - I hope this is helpful! ✌️

<Route path="/somewhere" component={Somewhere}/>
</Route>
</Router>
), document.getElementById('example'))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this particular edge case needs an example for it. Please remove it.

), node, function () {
const link1 = node.querySelectorAll('a')[0]
const link2 = node.querySelectorAll('a')[1]
const link3 = node.querySelectorAll('a')[1]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be [2]

@taion
Copy link
Contributor

taion commented Sep 9, 2016

LGTM

@timdorr timdorr merged commit 3281ed8 into remix-run:master Sep 9, 2016
sanniassin pushed a commit to sanniassin/react-router that referenced this pull request Jun 22, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants