Add Support for "Blank" Link components. #3803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
examples/empty-links/app.js
Outdated
| <Route path="/somewhere" component={Somewhere}/> | ||
| </Route> | ||
| </Router> | ||
| ), document.getElementById('example')) |
There was a problem hiding this comment.
I don't think this particular edge case needs an example for it. Please remove it.
modules/__tests__/Link-test.js
Outdated
| ), node, function () { | ||
| const link1 = node.querySelectorAll('a')[0] | ||
| const link2 = node.querySelectorAll('a')[1] | ||
| const link3 = node.querySelectorAll('a')[1] |
|
LGTM |
sanniassin
pushed a commit
to sanniassin/react-router
that referenced
this pull request
Jun 22, 2017
1 task
Closed
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, folks!
This PR addresses Issue #2319. It allows Link components to render anchor tags without
hrefs when thetoprop is not specified.Love to hear what you think - I hope this is helpful! ✌️