refactor(Route): simplify nested Ternary Conditional Operator

[izayl]

It's hard to manage and understand use so many nested Ternary Conditional Operator.

So I refactor it to a more cleaner logic branch version.

[MeiKatz]

To be honest: instead of defining the method each time, define it as a class method and pass it the props as arguments. Also we should get rid of every ternary operator. Maybe the solution is something like the following:

renderRouteChild(props) {
  if (!props.match) {
    if (typeof props.children !== "function") {
      return null;
    }

    if (__DEV__) {
      return evalChildrenDev(props.children, props, props.path);
    }

    return props.children(props);
  }

  if (props.children) {
    if (typeof props.children !== "function") {
      return props.children;
    }

    if (__DEV__) {
      return evalChildrenDev(props.children, props, props.path);
    }

    return props.children(props);
  }

  if (props.component) {
    return React.createElement(props.component, props);
  }

  if (props.render) {
    return props.render(props);
  }

  return null;
}

Now we can use it like this:

return (
  <RouterContext.Provider value={props}>
    {this.renderRouteChild({
      ...props,
      match: match,
      path: this.props.path,
    })}
  </RouterContext.Provider>
);

[izayl]

@MeiKatz You're right, Thank you for your advice

[MeiKatz]

@izayl and now get rid of the remaining ternary operators ;)

[MeiKatz]

@izayl Thank you 👍 I would approve your pull request but I am not authorized to do so. Maybe @timdorr?

[timdorr]

Eh, I don't want to get into the whole philosophical debate of ternary vs if/then. I've stated before that this form is more readable, but I know Ryan and Michael disagree. It’s a pedantic argument, so I don’t think it’s worth having yet again. I’ll leave it up to them if they want to accept this.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
You can add the fresh label to prevent me from taking any action.