-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the parity plot function legend settings #669
Conversation
Codecov Report
@@ Coverage Diff @@
## main #669 +/- ##
==========================================
- Coverage 73.48% 73.17% -0.32%
==========================================
Files 99 99
Lines 26488 26427 -61
Branches 5541 5535 -6
==========================================
- Hits 19466 19338 -128
- Misses 5659 5722 +63
- Partials 1363 1367 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thanks for the contribution @MichalKesl! Great job! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MichalKesl! I added some minor comments and questions. Let's test it in an ARC run for thermo
thermo_parity_plots.pdf |
Thanks! While we make the titles fancier, could you make H298 and S298 be something like |
183199a
to
54106f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can you take a look at one pending comment?
Can you upload an example of the plot?
@MichalKesl, thanks, looking good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! LGTM.
Fixed the legend settings for the parity plot and changed the units and the title of the plot to be written in Latex.