Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing time based observable #236

Merged
merged 3 commits into from
Mar 22, 2020
Merged

Fixing time based observable #236

merged 3 commits into from
Mar 22, 2020

Conversation

teivah
Copy link
Member

@teivah teivah commented Mar 22, 2020

Fixing #234

@teivah teivah changed the base branch from master to develop March 22, 2020 09:30
@coveralls
Copy link

Pull Request Test Coverage Report for Build 770

  • 93 of 146 (63.7%) changed or added relevant lines in 1 file are covered.
  • 28 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-1.2%) to 82.914%
Changes Missing Coverage Covered Lines Changed/Added Lines %
observable_operator.go 93 146 63.7%
Files with Coverage Reduction New Missed Lines %
item.go 2 92.98%
observable.go 5 85.29%
observable_operator.go 21 79.96%
Totals Coverage Status
Change from base Build 758: -1.2%
Covered Lines: 2771
Relevant Lines: 3342
💛 - Coveralls

@teivah teivah merged commit 037b748 into develop Mar 22, 2020
@teivah teivah deleted the time-fix branch March 22, 2020 09:39
@teivah teivah mentioned this pull request Mar 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teivah @coveralls