Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zip/Map/Select with index #372

Closed
samuelgruetter opened this issue Sep 11, 2013 · 4 comments
Closed

Zip/Map/Select with index #372

samuelgruetter opened this issue Sep 11, 2013 · 4 comments

Comments

@samuelgruetter
Copy link
Contributor

I'm looking for a function corresponding to this Rx C# function:

http://msdn.microsoft.com/en-us/library/hh244311(v=vs.103).aspx

Do we already have this in RxJava? I'm asking this because I want to implement the zipWithIndex function in the Scala adaptor.
@benjchristensen
Copy link
Member

No we do not have that yet. Your naming convention will be what we need to use so we don't overload methods with functions of different arities as that causes issues.

So mapWithIndex and zipWithIndex make sense.

@samuelgruetter
Copy link
Contributor Author

I'd be happy with mapWithIndex and zipWithIndex.

@jmhofer
Copy link
Contributor

jmhofer commented Sep 13, 2013

I don't think we have the arity problem with map (mapWithIndex), or do we? I think it should be specific to zip. So we could name it map instead of mapWithIndex if we wanted to. But probably we should be consistent and still call it mapWithIndex.

@jmhofer
Copy link
Contributor

jmhofer commented Sep 13, 2013

I take that back. I just experimented with this and noticed that at least Clojure does indeed have a problem with that. So mapWithIndex it is.

@jmhofer jmhofer mentioned this issue Sep 13, 2013
Merged
jihoonson pushed a commit to jihoonson/RxJava that referenced this issue Mar 6, 2020
@Romeh @RobWin
Rx retry exclude error#317 (ReactiveX#372)
1efa603 
* Add response predicate to retry sync and async for enhancement ReactiveX#259

* ReactiveX#317 skipping Java Error type from onError Rx retry transformer

* ReactiveX#317 adding proper comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jmhofer @benjchristensen @samuelgruetter