Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Gradle wrapper for Android samples to Gradle 1.11 #1020

Merged

Conversation

mttkay
Copy link
Contributor

@mttkay mttkay commented Apr 5, 2014

Android Studio 0.5.4 refuses to build with 1.10.

Android Studio 0.5.4 refuses to build with 1.10
@cloudbees-pull-request-builder

RxJava-pull-requests #943 ABORTED

@benjchristensen
Copy link
Member

There is a bug in our deploy process to Maven Central that is holding us back on Gradle 1.8. Can this wait another 4-8 weeks until we get the fix that allows us to move forward? If not, I'll have to downgrade to 1.8 every time I do a release then upgrade again.

@mttkay
Copy link
Contributor Author

mttkay commented Apr 16, 2014

Hey Ben,

the samples module is self contained and ships its own Gradle wrapper. Its
build is decoupled and triggered through an intermediary module
(android-samples-build-wrapper) that is part of the main build, but that
should be unaffected.

That said, it should cause no harm to merge this. Did you run into any
issues? I can double check.

@benjchristensen
Copy link
Member

Oh right ... I saw the change but didn't pay attention to it being only inside Android samples. Sorry about that ...

benjchristensen added a commit that referenced this pull request Apr 16, 2014
Upgrade Gradle wrapper for Android samples to Gradle 1.11
@benjchristensen benjchristensen merged commit f045aeb into ReactiveX:master Apr 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants