OperatorConcat #1074
Merged
OperatorConcat #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RxJava-pull-requests #987 FAILURE |
|
RxJava-pull-requests #988 SUCCESS |
| final NotificationLite<Observable<? extends T>> nl = NotificationLite.instance(); | ||
| @Override | ||
| public Subscriber<? super Observable<? extends T>> call(final Subscriber<? super T> child) { | ||
| final SerializedSubscriber<T> s = new SerializedSubscriber<T>(child); |
There was a problem hiding this comment.
Since concat is only ever subscribed to one Observable at a time, do we actually need to do serialization?
There was a problem hiding this comment.
Yes, because the outer observable can emit onError while the inner is running.
There was a problem hiding this comment.
Ah, it's the error case. Thanks!
|
I am merging despite having the question about serialization as that's an optimization question. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operator Concat
Issue #1060