Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SwingScheduler: allow negative schedule #1195

Merged
merged 2 commits into from
May 16, 2014
Merged

SwingScheduler: allow negative schedule #1195

merged 2 commits into from
May 16, 2014

Conversation

akarnokd
Copy link
Member

Fix for issue #1193

The new schedulePeriodic may calculate negative delay times if the next task was already due. This change will allow negative timing on the swing scheduler indicating an immediate schedule.

@akarnokd akarnokd changed the title Negative schedule time now indicates immediate execution. SwingScheduler: allow negative schedule May 12, 2014
@cloudbees-pull-request-builder
Copy link

RxJava-pull-requests #1106 FAILURE
Looks like there's a problem with this pull request

@zsxwing
Copy link
Member

zsxwing commented May 13, 2014

I suggest adding some comments in the Scheduler.schedule and Schedule.schedulePeriodically about negative timing. E.g., "negative delay time should be regarded as 0". It would be helpful for anyone who wants to implement special Scheduler.

@akarnokd
Copy link
Member Author

I've added extra comments.

@cloudbees-pull-request-builder
Copy link

RxJava-pull-requests #1109 FAILURE
Looks like there's a problem with this pull request

benjchristensen added a commit that referenced this pull request May 16, 2014
@benjchristensen
Merge pull request #1195 from akarnokd/SwingSchedulerNegativeFix
d64b3a1 
SwingScheduler: allow negative schedule
@benjchristensen benjchristensen merged commit d64b3a1 into ReactiveX:master May 16, 2014
@akarnokd akarnokd deleted the SwingSchedulerNegativeFix branch May 16, 2014 06:44
@benjchristensen benjchristensen mentioned this pull request Jun 1, 2014
Closed
@benjchristensen benjchristensen mentioned this pull request Jul 24, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akarnokd @cloudbees-pull-request-builder @zsxwing @benjchristensen