Publish, Replay and Cache Operators #260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cache operator as discussed in ReactiveX#209 Similar to `replay()` except that this auto-subscribes to the source sequence. This comes with the same cautions as `toList` when dealing with infinite or very large sequences.
|
RxJava-pull-requests #129 FAILURE |
|
RxJava-pull-requests #130 SUCCESS |
|
If anyone has comments on this I'd appreciate them in the next 12 hours otherwise I'll release a new version with these and the last few pull requests I've merged. |
| @Override | ||
| public void run() { | ||
| counter.incrementAndGet(); | ||
| System.out.println("published observable being executed"); |
There was a problem hiding this comment.
Maybe remove the debug outputs?
There was a problem hiding this comment.
Yes I could do that ... though I'm glad this is a unit test and not in the actual production code or that would be embarrassing that I left it in :-)
|
Completed in #263 after merging with other pull requests that caused conflicts. |
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
…actor-mono-tofuture-success ReactiveX#245 Fix CircuitBreakerSubscriber for Reactor doesn't count successes…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added basic Publish (#15) and Replay (#71) operators to Observable. I have not done any of the overloads (particularly
Replaywhich has 10+ in .Net.I also added a new
Cacheoperator as discussed by @johngmyers and I at #209.Playing with
ReplayandConnectableObservableit does not cater well to the typical use case of needing to just de-dupe calls (cache the responses) so thisCacheoperator can be thought of as an automatic version ofReplay. It comes with the same risk astoListif used with infinite or very large sequences as you can not unsubscribe from it.