add backpressure support for defaultIfEmpty() #3042
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking at implementing backpressure support for
defaultIfEmpty
the obvious strategy is to reuseswitchIfEmpty
and get rid ofOperatorDefaultIfEmpty
. That's what this PR does.There is a little bit of overhead with using
Observable.from(Arrays.asList(defaultValue))
as the alternate observable. Might be nice to have a version ofObservable.just(item)
that supports backpressure to use in its place (you've mentioned this before @akarnokd).