Fixed the issues of takeLast(items, 0) and null values #413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
There are two issues about
takeLast
#85 #140. The essential cause isLinkedBlockingDeque
.takeLast
in RxJava will throw an exception when count == 0, asLinkedBlockingDeque
rejects count <= 0. However, in c#, TakeLast with 0 count is valid. The following codes is OK in C# (no exception and do nothing):LinkedBlockingDeque requires the elements can not be null but an observable can emit a null value.
I used
ReentrantLock
andLinkedList
to replaceLinkedBlockingDeque
. Please take a look. Thanks.