-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Operation SkipUntil #541
Operation SkipUntil #541
Conversation
RxJava-pull-requests #472 SUCCESS |
return new ResultManager(t1).init(); | ||
} | ||
/** Manage the source and other observers. */ | ||
class ResultManager implements Subscription, Observer<T> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ResultManager should be a private class.
RxJava-pull-requests #473 SUCCESS |
"... there is one difference: I've implemented the OtherObserver such a way that if it is empty, it calls onCompleted() on the client observer and terminates the whole setup ..." TakeUntil and SkipUntil are triggered by either onNext or onError (in which case the exception is propagated). So when the OtherObserver is empty the result is Observable.never() not Observable.empty()). PublishSubject source = PublishSubject.create();
|
RxJava-pull-requests #481 SUCCESS |
Operation SkipUntil
Issue #79