Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Opening and Closing historical artifacts. #573

Merged
merged 5 commits into from
Dec 8, 2013

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Dec 6, 2013

Issue #540

The build fails due Scala compiler error I don't understand:

[ant:scalac] RxJava\language-adaptors\rxjava-scala\src\main\s
cala\rx\lang\scala\Observable.scala:531: error: type mismatch;
[ant:scalac]  found   : x2.type (with underlying type rx.Observable[_ <: T])
[ant:scalac]  required: T
[ant:scalac]       Observable[T](x2)
[ant:scalac]                     ^
[ant:scalac] one error found
  def window[Closing](closings: () => Observable[Closing]): Observable[Observable[T]] = {
    val func : Func0[_ <: rx.Observable[_ <: Closing]] = closings().asJavaObservable
    val o1: rx.Observable[_ <: rx.Observable[_]] = asJavaObservable.window[Closing](func)
    val o2 = Observable[rx.Observable[_]](o1).map((x: rx.Observable[_]) => {
      val x2 = x.asInstanceOf[rx.Observable[_ <: T]]
      Observable[T](x2)
    })
    o2
  }

Could someone help me with this?

@cloudbees-pull-request-builder

RxJava-pull-requests #508 FAILURE
Looks like there's a problem with this pull request

@cloudbees-pull-request-builder

RxJava-pull-requests #509 SUCCESS
This pull request looks good

@cloudbees-pull-request-builder

RxJava-pull-requests #510 SUCCESS
This pull request looks good

benjchristensen added a commit that referenced this pull request Dec 8, 2013
Removed Opening and Closing historical artifacts.
@benjchristensen benjchristensen merged commit ae866be into ReactiveX:master Dec 8, 2013
rickbw pushed a commit to rickbw/RxJava that referenced this pull request Jan 9, 2014
Removed Opening and Closing historical artifacts.
@akarnokd akarnokd deleted the OpeningClosingRemoved branch January 13, 2014 10:03
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
…e exception so that it is also possible to count exceptions as a success. (ReactiveX#573)

The list of ignored exceptions has always precedence. If an exception is ignored it neither counts as a success nor failure.
If the list of recorded exceptions only contains some exceptions, all others count as a success, unless they are not part of the list of ignored exceptions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants