Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Fix MulticastProcessor not requesting more after limit is reached #6715

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

akarnokd
Copy link
Member

After reaching the prefetch limit, the updated consumed counter was not written back so the processor stopped requesting more (consumed > limit).

Resolves #6713

@codecov
Copy link

codecov bot commented Nov 14, 2019

Codecov Report

Merging #6715 into 2.x will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##               2.x    #6715      +/-   ##
===========================================
- Coverage     98.2%   98.19%   -0.01%     
+ Complexity    6350     6346       -4     
===========================================
  Files          677      677              
  Lines        45526    45527       +1     
  Branches      6333     6333              
===========================================
  Hits         44707    44707              
- Misses         260      263       +3     
+ Partials       559      557       -2
Impacted Files Coverage Δ Complexity Δ
...va/io/reactivex/processors/MulticastProcessor.java 98.67% <100%> (+0.44%) 84 <0> (+1) ⬆️
...tivex/internal/observers/FutureSingleObserver.java 94.33% <0%> (-3.78%) 24% <0%> (-1%)
...a/io/reactivex/internal/util/QueueDrainHelper.java 97.22% <0%> (-2.78%) 56% <0%> (-2%)
...activex/internal/observers/QueueDrainObserver.java 97.43% <0%> (-2.57%) 21% <0%> (-1%)
.../internal/disposables/ListCompositeDisposable.java 98% <0%> (-2%) 34% <0%> (-1%)
.../io/reactivex/disposables/CompositeDisposable.java 98.14% <0%> (-1.86%) 39% <0%> (-1%)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 91.78% <0%> (-0.97%) 2% <0%> (ø)
...operators/observable/ObservableMergeWithMaybe.java 99.1% <0%> (-0.9%) 2% <0%> (ø)
...rnal/operators/flowable/FlowableFlatMapSingle.java 92.93% <0%> (-0.55%) 2% <0%> (ø)
...nternal/operators/observable/ObservableReplay.java 98.37% <0%> (-0.55%) 20% <0%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52dee7d...d92d081. Read the comment docs.

@akarnokd akarnokd merged commit aeb5f2c into ReactiveX:2.x Nov 14, 2019
@akarnokd akarnokd deleted the MulticastProcessorFix2x branch November 14, 2019 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants