-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Javadoc cleanup 1203 #6746
Javadoc cleanup 1203 #6746
Conversation
Whoa, that's definitively incorrect. Looks like you started with a very old commit. You should checkout 2.x from this repo, not your.older fork. |
Okay, so it only needed retargeting. You have to select the target branch next time you create a PR for 2.x as the default is 3.x. |
Codecov Report
@@ Coverage Diff @@
## 2.x #6746 +/- ##
============================================
+ Coverage 98.24% 98.26% +0.01%
+ Complexity 6350 6345 -5
============================================
Files 677 677
Lines 45532 45532
Branches 6334 6334
============================================
+ Hits 44733 44742 +9
+ Misses 251 244 -7
+ Partials 548 546 -2
Continue to review full report at Codecov.
|
@akarnokd Yes my apologies, I did not click on the right branch. Do I have to make another PR to fix it or is it taken care of? |
No need for a new PR, I could change the target to 2.x and it is now okay. |
@akarnokd Can you rephrase that for me, please? |
No need for a new PR, I could change the target to 2.x and it is now okay. |
@akarnokd Okay great, nothing else left for me to do on this particular issue? |
I don't think so, unless one of our regular reviewers finds something I overlooked. |
@akarnokd ok great. What else can I help with? |
Can't think of anything else right now. |
This PR is simply a backport of #6729 to the RxJava 2.x branch.