Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Rename to combineLatestArrayDelayError #6838

Merged
merged 1 commit into from
Jan 13, 2020

Conversation

akarnokd
Copy link
Member

The operator missed a rename with 2.x to match the combineLatestArray variant.

Resolves #6820

@akarnokd akarnokd added this to the 3.0 milestone Jan 13, 2020
@codecov
Copy link

codecov bot commented Jan 13, 2020

Codecov Report

Merging #6838 into 3.x will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6838      +/-   ##
============================================
+ Coverage     98.24%   98.31%   +0.06%     
- Complexity     6376     6382       +6     
============================================
  Files           715      715              
  Lines         46532    46532              
  Branches       6388     6388              
============================================
+ Hits          45715    45746      +31     
+ Misses          293      275      -18     
+ Partials        524      511      -13
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/reactivex/rxjava3/core/Flowable.java 100% <100%> (ø) 576 <1> (ø) ⬇️
...ain/java/io/reactivex/rxjava3/core/Observable.java 100% <100%> (ø) 552 <1> (ø) ⬇️
...tivex/rxjava3/internal/jdk8/ParallelCollector.java 93.57% <0%> (-4.59%) 2% <0%> (ø)
...nternal/operators/observable/ObservableWindow.java 98.18% <0%> (-1.82%) 3% <0%> (ø)
...ternal/operators/completable/CompletableMerge.java 95.94% <0%> (-1.36%) 2% <0%> (ø)
...ava3/internal/operators/maybe/MaybeMergeArray.java 96.04% <0%> (-1.13%) 6% <0%> (ø)
...perators/observable/ObservableMergeWithSingle.java 99.05% <0%> (-0.95%) 2% <0%> (ø)
...nternal/operators/observable/ObservableCreate.java 97.43% <0%> (-0.86%) 2% <0%> (ø)
.../operators/maybe/MaybeFlatMapIterableFlowable.java 95.9% <0%> (-0.82%) 2% <0%> (ø)
.../io/reactivex/rxjava3/subjects/UnicastSubject.java 98.03% <0%> (-0.66%) 61% <0%> (-1%)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c67263f...3164f90. Read the comment docs.

@akarnokd akarnokd merged commit 4dd4a65 into ReactiveX:3.x Jan 13, 2020
@akarnokd akarnokd deleted the CombineLatestArrayDelayErrorRename branch January 13, 2020 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.x: Rename combineLatestDelayError(array) to combineLatestArrayDelayError
1 participant