Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Fix many marbles in Maybe #6866

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Jan 24, 2020

Add many missing and replace incorrect marble diagrams in Maybe.

image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image

@codecov
Copy link

codecov bot commented Jan 24, 2020

Codecov Report

Merging #6866 into 3.x will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6866      +/-   ##
============================================
- Coverage     98.23%   98.21%   -0.03%     
- Complexity     6379     6381       +2     
============================================
  Files           715      715              
  Lines         46528    46528              
  Branches       6388     6388              
============================================
- Hits          45709    45698      -11     
- Misses          292      307      +15     
+ Partials        527      523       -4
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/rxjava3/core/Maybe.java 100% <ø> (ø) 180 <0> (ø) ⬇️
...a3/internal/operators/flowable/FlowableCreate.java 90.29% <0%> (-7.12%) 6% <0%> (ø)
...nternal/operators/observable/ObservableCreate.java 97.43% <0%> (-1.71%) 2% <0%> (ø)
...ternal/operators/observable/ObservableFlatMap.java 89.63% <0%> (-1.01%) 3% <0%> (ø)
...perators/observable/ObservableMergeWithSingle.java 99.05% <0%> (-0.95%) 2% <0%> (ø)
...rxjava3/internal/schedulers/ExecutorScheduler.java 95.89% <0%> (-0.92%) 10% <0%> (ø)
...ternal/operators/observable/ObservableGroupBy.java 95.08% <0%> (-0.55%) 2% <0%> (ø)
...activex/rxjava3/processors/MulticastProcessor.java 98.25% <0%> (-0.44%) 82% <0%> (-2%)
...3/internal/operators/flowable/FlowableGroupBy.java 95.91% <0%> (-0.32%) 3% <0%> (ø)
...internal/operators/flowable/FlowableObserveOn.java 96.65% <0%> (-0.28%) 3% <0%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb3260e...3e35f81. Read the comment docs.

@akarnokd akarnokd merged commit 13473da into ReactiveX:3.x Jan 24, 2020
@akarnokd akarnokd deleted the MaybeDiagrams branch January 24, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant