Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Swap Maybe.flatMapSingle and Maybe.flatMapSingleElement #6891

Merged
merged 5 commits into from
Jan 28, 2020
Merged

3.x: Swap Maybe.flatMapSingle and Maybe.flatMapSingleElement #6891

merged 5 commits into from
Jan 28, 2020

Conversation

slisaasquatch
Copy link
Contributor

@slisaasquatch slisaasquatch commented Jan 28, 2020

Resolves #6878

Dropped the old Maybe.flatMapSingle and replaced it with Maybe.flatMapSingleElement

@akarnokd akarnokd changed the title Issue 6878 3.x: Swap Maybe.flatMapSingle and Maybe.flatMapSingleElement Jan 28, 2020
@slisaasquatch
Copy link
Contributor Author

Hmm for XFlatMapTest.maybeSingle, if I replace flatMapSingle().toSingle() with toSingle().flatMap(), then the test will pass.

@akarnokd
Copy link
Member

The test checks if disposing while in the function, the returned Single never gets subscribed to and thus no error is signaled to the downstream or the global error handler. Put an @Ignore on it for now and I'll look into the operator tomorrow.

@akarnokd akarnokd added this to the 3.0 milestone Jan 28, 2020
@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #6891 into 3.x will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6891      +/-   ##
============================================
+ Coverage     98.26%   98.26%   +<.01%     
+ Complexity     6596     6593       -3     
============================================
  Files           741      740       -1     
  Lines         47334    47293      -41     
  Branches       6432     6430       -2     
============================================
- Hits          46511    46473      -38     
- Misses          301      302       +1     
+ Partials        522      518       -4
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/rxjava3/core/Maybe.java 100% <100%> (ø) 208 <1> (-1) ⬇️
...3/internal/operators/maybe/MaybeFlatMapSingle.java 100% <100%> (ø) 2 <0> (ø) ⬇️
...tivex/rxjava3/internal/jdk8/ParallelCollector.java 89.9% <0%> (-8.26%) 2% <0%> (ø)
...xjava3/internal/observers/FutureMultiObserver.java 91.52% <0%> (-3.39%) 25% <0%> (-1%)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 92.7% <0%> (-2.61%) 2% <0%> (ø)
...a3/internal/operators/flowable/FlowableCreate.java 94.82% <0%> (-2.59%) 6% <0%> (ø)
...ternal/operators/completable/CompletableMerge.java 95.94% <0%> (-1.36%) 2% <0%> (ø)
...nternal/operators/observable/ObservableCreate.java 98.29% <0%> (-0.86%) 2% <0%> (ø)
.../operators/observable/ObservableCombineLatest.java 96.17% <0%> (-0.64%) 6% <0%> (ø)
...a/io/reactivex/rxjava3/subjects/ReplaySubject.java 97.14% <0%> (-0.41%) 50% <0%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3516b2...ccc3afb. Read the comment docs.

@akarnokd akarnokd merged commit f1a795d into ReactiveX:3.x Jan 28, 2020
@slisaasquatch slisaasquatch deleted the issue-6878 branch January 29, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.x: Swap Maybe.flatMapSingle and Maybe.flatMapSingleElement ?
2 participants