Change Lift to use rx.Observable.Operator #857
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generics insanity has to stop.
This pull request is a result of @abersnaze and I continuing to fail to make generics work with this signature:
It all fell apart while trying to do things that needed the equivalent of:
... and other such variants.
With this change I can also finally get the
OperatorMerge
generics to work.Thus, the
Operator
type exists insideObservable
just likeOnSubscribe
like this:This gives us imports like this:
I know it's not as pure as having
lift(Func1)
but this is far more usable.If anyone has a different suggestion that still solves the generics issue please let me know.