Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zip Bug UnitTest: Never Completes When Zero Observables (Obsolete) #868

Closed
wants to merge 0 commits into from
Closed

Conversation

tnine
Copy link
Contributor

@tnine tnine commented Feb 13, 2014

Hey guys,
I discovered this issue today in Rx. I'm not sure if it's a bug, or as designed. I've added the test. Can you let me know if it is in fact a bug, then I'll correct the issue?

@cloudbees-pull-request-builder

RxJava-pull-requests #795 FAILURE
Looks like there's a problem with this pull request

@tnine
Copy link
Contributor Author

tnine commented Feb 13, 2014

That failure is expected, my test currently fails to prove the issue.

@cloudbees-pull-request-builder

RxJava-pull-requests #796 FAILURE
Looks like there's a problem with this pull request

@benjchristensen
Copy link
Member

Yup, that's a bug. The OperatorZip code assumes it will always receive Observables to zip.

The line in question is here: https://github.com/Netflix/RxJava/blob/master/rxjava-core/src/main/java/rx/operators/OperatorZip.java?source=c#L110

@tnine
Copy link
Contributor Author

tnine commented Feb 21, 2014

See #917 for PR. I had to move this fix on master to it's own branch so I can continue to track the main master. #917 Supersedes this PR.

@tnine tnine closed this Feb 21, 2014
@cloudbees-pull-request-builder

RxJava-pull-requests #855 SUCCESS
This pull request looks good

benjchristensen added a commit to benjchristensen/RxJava that referenced this pull request Feb 21, 2014
benjchristensen added a commit to benjchristensen/RxJava that referenced this pull request Feb 21, 2014
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants