Allow PHP 8 and Update PHPUnit #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
asm89
approved these changes
Dec 12, 2020
.travis.yml
Outdated
|
|
||
| after_success: | ||
| - travis_retry php vendor/bin/coveralls -v | ||
| - travis_retry php vendor/bin/coveralls -v |
There was a problem hiding this comment.
I don't remember removing that. I will take a look.
Comment on lines
+80
to
+81
| // allow demos without expect files - we will just get a warning later | ||
| // assert(file_exists($outputPath), "output does not exist $outputPath"); |
There was a problem hiding this comment.
Why does this need to be removed? Perhaps we can skip and print a warning for now if the output path does not exist?
There was a problem hiding this comment.
In PHP 7 this generated a warning and the tests still passed. With PHP 8 this generates a fatal error and stops.
A warning is still generated later when file_get_contents is called, but the tests still work.
| * @param callable $comparer Comparer to determine causality of events based on absolute time. | ||
| */ | ||
| public function __construct(int $initialClock = 0, callable $comparer) | ||
| public function __construct(int $initialClock, callable $comparer) |
There was a problem hiding this comment.
Interesting. I guess this went unnoticed before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.