Skip to content

Fix async examples. Fixes #364 #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2019
Merged

Fix async examples. Fixes #364 #402

merged 2 commits into from
May 30, 2019

Conversation

dbrattli
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented May 30, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 92.61% when pulling 8ce072a on feature/fix-async-examples into 84ff8c0 on master.

erikkemperman
erikkemperman approved these changes May 30, 2019
View reviewed changes
Copy link
Collaborator

@erikkemperman erikkemperman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coveralls seems to be confused, it reports dropped coverage on eventletscheduler, which I don't think has anything to do with this PR?

@dbrattli
Copy link
Collaborator Author

Thanks for reviewing!

@dbrattli dbrattli merged commit 8e7169d into master May 30, 2019
@dbrattli dbrattli deleted the feature/fix-async-examples branch June 10, 2019 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikkemperman erikkemperman erikkemperman approved these changes

@jcafhe jcafhe jcafhe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dbrattli @coveralls @erikkemperman @jcafhe