Application crash sending text selector to RxTableViewDelegateProxy or RxCollectionViewDelegateProxy
#2428
Comments
|
We are seeing a similar issue Cannot reproduce but can confirm it is limited to iOS 15.4+ even though we support iOS 13+. Our Xcode Crash Reports highlight the line We tried upgrading from 6.2.0 to 6.5.0 but it did not help. |
|
If your crash report system allows it... it might help if you can figure out the type of the instance that is receiving the message. To do it, you would have to output several object's memory locations and compare to the one highlighted in the bug. |
|
I think the crash says what it is. The |
|
We have the exact same issue. And we have been unable to reproduce the issue. Upgrading RxSwift and RxCocoa won't help. |
|
Can you share the entire crash log? |
|
It's happening to us and it's currently the most significant crash in our app. Can confirm everything what was outlined here (iOS 15+, both RxSwift 6.2 and 6.5). |
|
It's from Crashlytics there doesn't seem to be a DL button so here's a cleaned up copy/paste of the entire trace: |
|
As @mkj-is said about this crash in our application, I would like to add my ideas: |
|
It looks like react native is also having a problem with |
|
I went back and looked and can confirm what @mwilson-within said, the OS version for this crash are not just any flavor of iOS15 but specifically iOS15.4 and later if that helps. |
There is a good point, this could be some internal change in accessibility. It looks like the system is traversing the view hierarchy and when it encounters the |
|
We're having the exact same crash within our app, iOS version 15+, been tracking it for weeks trying to find solutions. We've tried upgrading to the latest Rx release but it doesn't seem to solve the issue. |
|
We've just found this issue and also has been happening since iOS 15.4+ |
|
Hey all, To seriously look into this I need a non-Firebase crash report. Meaning an entire non-obfuscated crash report or xccrashpoint file that I can look into would be immensely helpful. Looking at some of the traces here this doesn't seem like something we could necessarily work around but more like a regression in iOS itself, but I'm happy to try and look into this if I get detailed enough crash details. Thanks! |
|
Looking over the implementation of "DelegateProxy.swift" and "_RXDelegateProxy.m", I'm not sure the logic is correct. In "DelegateProxy.swift", "responds(to..." is checking super: super.responds(to: aSelector) But in "_RXDelegateProxy.m", "forwardInvocation" is ignoring super. The problem is that if the base class object also chooses to use object proxying, then the first check will return true (because the base class DOES respond to the selector) but the forwardInvocation call will fail with "selector not found"(since the message was never forward to "super", which would have responded). |
2022-06-07_23-03-54.9047_+0400-601c39d876053890e09ae677c7fd948089429656.crash.log |
|
We are seeing a similar issue NSInvalidArgumentException |
|
Any updates? |
|
I've got nothing but over the last 90 days we have almost 25k crashes on this over 10.5k users. It accounts for 60% of all of our crashes over that time and the next biggest one accounts for 5%. It's a doozy and I can't reproduce it myself 😭 |
|
We are experimenting with this patch. We don't have conclusive results yet. I will update you when we do. But the root cause is still unknown. @objc
extension RxCollectionViewDelegateProxy {
var text: String {
return String()
}
} |
@mkj-is we only have 3 days of it being live, but so far no crashes on the version with this patch in place in our app. I'll update with any changes if more crashes happen with this patch in place. |
|
We'll give this a try as well. It's a workaround as it doesn't solve why something thinks the proxy should have a |
This fix is working good.
that Question is why |
|
I'm OK with taking a PR for this "workaround" if anyone has some time to make one. |
|
-deleted- |
|
Hello @mkj-is , |
|
@rajaraph Any more details? What did you do with Siri to cause it? Simply trying to use Siri with our app open did not cause the problem. The bright side I can confirm that the extension fix above to "eat" the errant method calls works for us as well, no new crashes since we sent a build out with this fix. I'd still like to get to the bottom of this though because until the repo itself is corrected in some way, basically every app that uses RxSwift is guaranteed to have tons of crashes on later OSes. |
|
@SlashDevSlashGnoll Yes we just try to use Siri and it crashes immediately |
|
Hey @SlashDevSlashGnoll @yan-zaitsev-hs - |
Implement crash workaround discussed here ReactiveX#2428 until a more permanent solution is found
Implement crash workaround discussed here ReactiveX#2428 until a more permanent solution is found
|
PR opened! #2445 |
|
Thank you! |
Implement crash workaround discussed here #2428 until a more permanent solution is found
|
Will we have a new release version of this workaround? Like |
|
I have a same issue, but in Firebase Crash Log，It shows that: In Xcode Crash Log: Anyway, I will see if this Extension works |
It didn't work for me |
|
@liweican1992 That is because Since this bug is present in more FRP project I suspect this is indeed caused by some internal change in iOS. @objc
extension RACDelegateProxy {
var text: String {
return String()
}
} |
|
@liweican1992 Are you even using RxSwift in your project? Or are you using ReactiveObjC? The crash you listed shows the same problem but for a class as part of the ReactiveObjC project shown here. If so apply a similar patch there for |
@mkj-is @SlashDevSlashGnoll Thank you very much. We used ReactiveCocoa and RxSwift in our project, and the crash did resolve with this extension. The crash happened mostly in the ads show, some advertising SDK caused this strange bug |
|
I'm receiving same issue, but for Added extension to it in a similar way to what is shown for collection/tableViews, but for ScrollView. Crash appeared again. Do you think adding |
Implement crash workaround discussed here ReactiveX#2428 until a more permanent solution is found
|
Small update: 
In our project, we not only added |
|
Guys please check our solution for this crash #2546 |
As i see this MR is merged. May you say when new release will be? |
Short description of the issue:
We're seeing a crash among our userbase that is happening with alarming frequency however we have been unable to reproduce it or identify the root cause. A slack discussion was started here among 2 of us that are seeing this problem but we wanted to post here with the hopes that someone else may have an idea about something to look at.
This is the stack trace/crash:
I have scoured our code to see if we were somehow sending a text selector to anything in a weird way, this is not the case. Our app is large and uses tables in many screens but I haven't found any misuse of
rx.tems.Here are the pertinent facts I've been able to collect about the problem:
This crash is alarming because it seems to only occur on iOS15. Users from previous versions of iOS do not exhibit this problem. We haven't been able to determine if this is a bug in iOS, a bug in RxSwift or a bug in our usage of it. The os-specific nature of it makes me wonder if there's an iOS bug or a bug in the RxSwift framework that just hasn't come to light yet.
Any insights would be greatly appreciated.
Expected outcome:
No crashes
What actually happens:
Crash
Self contained code example that reproduces the issue:
I wish I had one or I'd be able to identify the problem :(
RxSwift/RxCocoa/RxBlocking/RxTest version/commit
RxSwift 6.2.0 - 7c17a6c
Platform/Environment
How easy is to reproduce? (chances of successful reproduce after running the self contained code)
About 3% of our userbase is experiencing this. This includes users of other versions of iOS however that do not experience the issue at all.
Xcode version:
Installation method:
I have multiple versions of Xcode installed:
(so we can know if this is a potential cause of your issue)
Level of RxSwift knowledge:
(this is so we can understand your level of knowledge
and formulate the response in an appropriate manner)
The text was updated successfully, but these errors were encountered: