Skip to content
This repository was archived by the owner on Oct 1, 2018. It is now read-only.

Conversation

btroncone
Copy link
Collaborator

Closes #90

@codecov-io
Copy link

codecov-io commented Dec 2, 2017

Codecov Report

Merging #176 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #176   +/-   ##
=======================================
  Coverage   85.71%   85.71%           
=======================================
  Files           8        8           
  Lines          91       91           
  Branches        4        4           
=======================================
  Hits           78       78           
  Misses         13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1b1ad5...9716b54. Read the comment docs.

{ age: 6, name: 'Foo'}
)
.distinctUntilChanged((p, q) => p.name === q.name)
// displays:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move the displays block after the subscribe to make the chain a bit more clear ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I updated the JSBin links and removed from ts files as this is just used for copy / paste.

code: `
Rx.Observable.of(1, 1, 2, 2, 2, 1, 1, 2, 3, 3, 4)
.distinctUntilChanged()
// displays
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move the displays block after the subscribe to make the chain a bit more clear ?

@ashwin-sureshkumar ashwin-sureshkumar merged commit f65c556 into ReactiveX:master Dec 3, 2017
@ladyleet
Copy link
Member

ladyleet commented Dec 3, 2017

@btroncone woot thanks brian! :) and thx @ashwin-sureshkumar and @sumitarora for reviewing <3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants