Skip to content

Conversation

grogy
Copy link
Contributor

@grogy grogy commented Sep 23, 2017

Hi,

I am trying how add this tool to project with older PHP. Here is described setup. What do you think about it?

@grogy grogy mentioned this pull request Sep 24, 2017
README.md Outdated
@@ -21,6 +21,21 @@ At the moment these packages are supported:
composer require rector/rector --dev
```

# Install on PHP < 7.1

You must have separated environment with PHP 7.1 (for example in Docker container). When you have it then run next command. The reason for this difficulty setup is your dependencies are only PHP <7.1 compatible and you cannot add 7.1.x package.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • run next => run following
  • "The reason for this difficulty setup is your dependencies are only PHP <7.1 compatible and you cannot add 7.1.x package."
    • I think this information is already included in the title.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

README.md Outdated
You must have separated environment with PHP 7.1 (for example in Docker container). When you have it then run next command. The reason for this difficulty setup is your dependencies are only PHP <7.1 compatible and you cannot add 7.1.x package.

```
composer create-project rector/rector your-path-to-rector
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this!

README.md Outdated

```
your-path-to-rector/bin/rector reconstruct src --level=nette24
your-path-to-rector/bin/rector reconstruct src --level=symfony40
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case maybe more common use case will be:

your-path-to-rector/bin/rector reconstruct /var/www/old-project --level=nette24
your-path-to-rector/bin/rector reconstruct /var/www/another-old-project --level=symfony40

In words: reconstruct more code projects that are not co-located with Rector directory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@TomasVotruba TomasVotruba merged commit d367b1d into rectorphp:master Oct 1, 2017
@TomasVotruba
Copy link
Member

Thank you, merged 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants