Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License cleanup help #4

Closed

Conversation

siwinski
Copy link

I am not a lawyer or a member of Red Hat's legal team, but I noticed that the license information in this package is off. This pull request is an attempt to help clean that up based on my knowledge of other open source packages.

Changes:

  • Change license file name from OFL.md to LICENSE.md because this package is dual-licensed (not just OFL) and this is the standard license file name to use
  • Update README to link to the license file instead of specifying 1 of 2 licenses (and no need to list the text twice)
  • Fix package.json license value

Questions I still have about this package:

  • Is the LGPL licensing really just 2.1 or is it 2.1+?
  • Did Red Hat legal review and approve both the licensing of this package and the format of the license file?

@starryeyez024 @rethomps @castastrophe

- Change license file name from `OFL.md` to `LICENSE.md` because this package is dual-licensed (not just OFL) and this is the standard license file name to use
- Update README licence to link to the license file instead of specifying 1 of 2 licenses (and no need to list the text twice)
- Fix `package.json` license value
    - https://docs.npmjs.com/files/package.json#license
    - https://spdx.org/licenses/
@siwinski
Copy link
Author

The README file also references the "SIL license" twice in its' description. Is this repo licensed under a third license as well?

@starryeyez024
Copy link
Member

per this question:
Did Red Hat legal review and approve both the licensing of this package and the format of the license file?

Yes. I did send them this PR though.

@richardfontana richardfontana mentioned this pull request Mar 27, 2019
@@ -12,5 +12,5 @@
"Hat"
],
"author": "",
"license": "SEE LICENSE IN OFL.md"
"license": "(OFL-1.1 OR LGPL-2.1)"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OFL-1.1 only please :)

@richardfontana
Copy link
Contributor

@starryeyez024 @siwinski This should be closed in favor of the in-progress #7 - the main difference is that this keeps the OFL|LGPL dual license (even though @siwinski rightly found that peculiar) and @davelab6 is right that, at least since we're trying to fix this up anyway, we shouldn't have an LGPL license option because it's just confusing at best and no real-world user will benefit from such an option.

@siwinski
Copy link
Author

Closing per last comment. Thanks @richardfontana !

@siwinski siwinski closed this Apr 15, 2019
@davelab6
Copy link

davelab6 commented Apr 15, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants