Add support for jiras with multiple fix versions and refactor relevant tests

[rnetser]

Summary by CodeRabbit

• Bug Fixes

  • Improved detection and validation of multiple Jira fixVersions, ensuring all relevant versions are checked and matched accurately.

• Tests

  • Expanded and refactored test cases for better coverage, including scenarios with multiple target versions.
  • Added a new test to verify proper handling of Jira API errors.

[coderabbitai]

Walkthrough

The changes update the logic for extracting and validating Jira fixVersions in jira_information.py, allowing for multiple target versions and improved matching. The associated test suite is refactored for clarity, expanded with additional scenarios, and now includes a test for Jira API error handling. No public function signatures were modified.

Changes

Files/Groups	Change Summary
apps/jira_utils/jira_information.py	Enhanced version extraction logic to handle multiple fixVersions, updated validation, and error reporting.
tests/jira_utils/test_jira_utils.py	Refactored test function to use parameter dictionaries, expanded test cases, and added Jira API error test.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fb2f01e and 079400e.

📒 Files selected for processing (2)

• apps/jira_utils/jira_information.py (2 hunks)
• tests/jira_utils/test_jira_utils.py (4 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)

• GitHub Check: can-be-merged
• GitHub Check: can-be-merged
• GitHub Check: can-be-merged
• GitHub Check: can-be-merged
• GitHub Check: can-be-merged
• GitHub Check: python-module-install
• GitHub Check: tox

🔇 Additional comments (7)

apps/jira_utils/jira_information.py (3)

119-124: Improved logic for handling multiple fix versions

The logic correctly handles multiple fix versions by:

1. Initializing with target_version_str as fallback
2. Concatenating all fix version names with comma separator
3. Extracting all matching versions using the enhanced regex

This is a solid improvement that supports the PR objective of handling multiple fix versions.

---

125-133: Enhanced version validation logic

The validation logic now properly checks if any extracted version matches the expected target versions using any(), which is more robust than the previous single-version check. The error message correctly displays all current_target_versions for better debugging.

---

104-104: We need to inspect the surrounding code to see how target_version_str is handled before it's injected into the regex. Let's pull the context around the re_compile definition.

tests/jira_utils/test_jira_utils.py (4)

6-6: Good addition of JIRAError import

The import is correctly added to support the new error handling test.

---

77-198: Excellent refactoring to parameter dictionary structure

The refactoring from individual parameters to a dictionary structure significantly improves:

1. Readability: Each test case is self-contained with clear parameter names
2. Maintainability: Adding new parameters or test cases is easier
3. Coverage: Expanded from 9 to 12 test cases with comprehensive scenarios for multiple versions

The test cases properly cover:

• Multiple target versions (cases 10-12)
• Version matching with different combinations
• Edge cases with empty strings and z-versions

---

215-245: Clean test function implementation

The test function correctly:

1. Extracts parameters from the dictionary
2. Conditionally patches regex based on test_jira_versions
3. Calls the function with proper parameter mapping
4. Asserts the expected results

The conditional patching aligns with the updated logic that uses regex for version extraction.

---

292-308: Valuable addition of API error handling test

The new test properly validates that JIRAError exceptions are caught and formatted correctly in the error message. This adds important robustness to the test suite by ensuring proper error handling.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[redhat-qe-bot1]

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

• Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
• Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
• Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
• Pre-commit Checks: pre-commit runs automatically if .pre-commit-config.yaml exists
• Branch Labeling: Branch-specific labels are applied to track the target branch
• Auto-verification: Auto-verified users have their PRs automatically marked as verified

📋 Available Commands

PR Status Management

• /wip - Mark PR as work in progress (adds WIP: prefix to title)
• /wip cancel - Remove work in progress status
• /hold - Block PR merging (approvers only)
• /hold cancel - Unblock PR merging
• /verified - Mark PR as verified
• /verified cancel - Remove verification status

Review & Approval

• /lgtm - Approve changes (looks good to me)
• /approve - Approve PR (approvers only)
• /automerge - Enable automatic merging when all requirements are met (maintainers and approvers only)
• /assign-reviewers - Assign reviewers based on OWNERS file
• /assign-reviewer @username - Assign specific reviewer
• /check-can-merge - Check if PR meets merge requirements

Testing & Validation

• /retest tox - Run Python test suite with tox
• /retest python-module-install - Test Python package installation
• /retest all - Run all available tests

Container Operations

• /build-and-push-container - Build and push container image (tagged with PR number)
  • Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

• /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
  • Multiple branches: /cherry-pick branch1 branch2 branch3

Label Management

• /<label-name> - Add a label to the PR
• /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

1. Approval: /approve from at least one approver
2. LGTM Count: Minimum 0 /lgtm from reviewers
3. Status Checks: All required status checks must pass
4. No Blockers: No WIP, hold, or conflict labels
5. Verified: PR must be marked as verified (if verification is enabled)

📊 Review Process

Approvers and Reviewers

Approvers:

• dbasunag
• myakove
• rnetser

Reviewers:

• dbasunag
• myakove
• rnetser

Available Labels

• hold
• verified
• wip
• lgtm
• approve
• automerge

💡 Tips

• WIP Status: Use /wip when your PR is not ready for review
• Verification: The verified label is automatically removed on each new commit
• Cherry-picking: Cherry-pick labels are processed when the PR is merged
• Container Builds: Container images are automatically tagged with the PR number
• Permission Levels: Some commands require approver permissions
• Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

[rnetser]

/verified

[myakove]

/approve