Skip to content

initialize dataSize ion abstractInitParams in tiered factory NewIndex from hnsw file #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 24, 2024
Merged

initialize dataSize ion abstractInitParams in tiered factory NewIndex from hnsw file #578

merged 1 commit into from
Dec 24, 2024

Conversation

meiravgri
Copy link
Collaborator

@meiravgri meiravgri commented Dec 24, 2024 •
edited
Loading

Add datasize to the brute force index params when building a tiered index from a serialized hnsw index file.

@codecov Codecov
Copy link

codecov bot commented Dec 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.09%. Comparing base (babfbe0) to head (43d6b6e).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #578   +/-   ##
=======================================
  Coverage   97.09%   97.09%           
=======================================
  Files         104      104           
  Lines        5503     5503           
=======================================
  Hits         5343     5343           
  Misses        160      160

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meiravgri meiravgri added this pull request to the merge queue Dec 24, 2024
Merged via the queue into main with commit 63badf2 Dec 24, 2024
23 of 24 checks passed
@meiravgri meiravgri deleted the meiravg_fix_teired_build_from_index_datasize branch December 24, 2024 15:45
github-actions bot pushed a commit that referenced this pull request Dec 24, 2024
@meiravgri @github-actions
initialize dataSize ion abstractInitParams in tiered factory NewIndex…
2f0f749 
… from hnsw file (#578)

(cherry picked from commit 63badf2)
@github-actions GitHub Actions
Copy link

Successfully created backport PR for 8.0:

@github-actions github-actions bot mentioned this pull request Dec 24, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Dec 25, 2024
@github-actions @meiravgri
[8.0] initialize dataSize ion abstractInitParams in tiered factory Ne…
8f10c26 
…wIndex from hnsw file (#582)

initialize dataSize ion abstractInitParams in tiered factory NewIndex from hnsw file (#578)

(cherry picked from commit 63badf2)

Co-authored-by: meiravgri <109056284+meiravgri@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuyAv46 GuyAv46 GuyAv46 approved these changes

@alonre24 alonre24 Awaiting requested review from alonre24

Assignees
No one assigned
Labels
bm-basics-fp32-single
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meiravgri @GuyAv46