[8.2] [MOD-10236] Add serialization to SVS index #781
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
* generalize * remove serializer.cpp from cmake * prepare merge with rafik commit * [SVS] Implement Save/Load + test * seperate hnsw_serializer to h and cpp * remove get version impl * save impl * add load * change camelcase * for mat * generalzie saveIndexFields * format * compare metadata on load * Add checkIntegrity with error * checkIntegrity * remove duplicate verification in compare meta data * format * svs serializetion version testing * Revert "svs serializetion version testing" This reverts commit 9ed7730. * common serializer test * remove changes_num from metadata * Add location c'tor * Add location ctor and to test * Remove outdated comment from serializer header * Enhance documentation for loadIndex function in SVSIndex * Add comments * format + remove test * enable tests * serializer test * format * reset SVS to master * add logging to test_svs * format * remove duplicate NewIndexImpl * expose loadIndex in VecSimIndex, add BUILD_TEST gurad * remove string ctor from SVSIndex * format * fix BUILD_TEST in svs_factory * document loadIndex * move loadIndex to serializer * remove excess declarations * remove extra ; * compatable -> compatible * remove redundant params from test * remove comments from threadpool_handle * remove error context comments * add checkIntegrity * update checkIntegrity and format * move loadIndex to SVSSerializer * update bindings * format * add test * add single * adjust labels * Refactor save_load test to simplify vector generation logic * add HAVE_SVS guard * Add missing include for <sstream> in svs_serializer.h * free faulty index * Free index * Improve error message for index loading failure in NewIndex function * format --------- Co-authored-by: Rafik Saliev <rafik.f.saliev@intel.com> (cherry picked from commit f68bb6b)
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 8.2 #781 +/- ##
==========================================
- Coverage 96.87% 96.65% -0.23%
==========================================
Files 122 125 +3
Lines 7489 7680 +191
==========================================
+ Hits 7255 7423 +168
- Misses 234 257 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lerman25
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #716 to
8.2.