Skip to content

Conversation

hhsecond
Copy link

Addressing #124

@lantiga
Copy link
Contributor

lantiga commented Jun 11, 2019

On second though, this probably belongs to the examples repo. What do you think?

@hhsecond
Copy link
Author

hhsecond commented Jun 12, 2019

That's what my instinct was too. But then we have at least one example for each backend in this repo. If we are planning to remove all the examples from here, it make sense to move it there. Shall I go ahead and clean up the example folder here?

@lantiga
Copy link
Contributor

lantiga commented Jun 12, 2019

I agree, the examples folder needs to be cleaned up. However, some of it can go in redisai-examples, some as tests. Let's use this opportunity to see what goes where.

@K-Jo K-Jo merged commit 7a3d395 into RedisAI:master Jun 21, 2019
@K-Jo
Copy link
Collaborator

K-Jo commented Jun 21, 2019

I believe that both folder here and in ai-examples need a clean up. However keeping this dangling here now we made a release feels poor. I'll make a ticket to force us to clean this up

@hhsecond hhsecond deleted the onnx_example branch July 3, 2019 07:34
lantiga pushed a commit that referenced this pull request May 6, 2020
 
Merge pull request #139 from hhsecond/onnx_example

Example with onnx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants