Add possibility to provide a model in chunks #338
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing on of the HuggingFace models (1.3 GB),
MODELSET
was failing due to the fact that Redis strings are limited to 512 MB.This PR gives the possibility to provide a large model in chunks, overcoming the limitation (at the cost of a transient allocation + memcpy of a large chunk of memory, but for now there are no alternatives):
Note that the API has been changed. One now has to specify
BLOB
to signal the start of chunks:For consistency, the same was done for SCRIPTSET, with the addition of
SOURCE
:@hhsecond: we need to update the Python client both with
BLOB
andSOURCE
, as well as chunking (detect if blob is larger than 512 MB and chunk it tansparently)