Skip to content

Conversation

swilly22
Copy link
Contributor

@swilly22 swilly22 commented Sep 3, 2021

Resolves: #1914

@swilly22 swilly22 self-assigned this Sep 3, 2021
@swilly22 swilly22 added the bug label Sep 3, 2021
@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #1915 (563a864) into master (add3c07) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 563a864 differs from pull request most recent head 1bf7ac8. Consider uploading reports for the commit 1bf7ac8 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1915   +/-   ##
=======================================
  Coverage   86.55%   86.55%           
=======================================
  Files         247      247           
  Lines       21558    21559    +1     
=======================================
+ Hits        18660    18661    +1     
  Misses       2898     2898           
Impacted Files Coverage Δ
src/ast/ast_validations.c 89.25% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update add3c07...1bf7ac8. Read the comment docs.

@swilly22 swilly22 merged commit 2e5b698 into master Sep 4, 2021
@swilly22 swilly22 deleted the valid-query-parameters branch September 4, 2021 19:01
@swilly22 swilly22 changed the title validate functions ref within params [WIP] validate functions ref within params Sep 5, 2021
AviAvni pushed a commit that referenced this pull request Sep 5, 2021
* validate functions ref within params [WIP]

* test invalid query params
swilly22 added a commit that referenced this pull request Sep 5, 2021
* Update thread-local AST for every cloned op (#1913)

* Update thread-local AST for every cloned op

* address review

* add comment

* Update all_paths.c

Co-authored-by: Avi Avni <avi.avni@gmail.com>
Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>

* cron task abort [WIP] (#1911)

* cron task abort [WIP]

* test task abort

* relaxed memory model synchronization modes

* validate functions ref within params [WIP] (#1915)

* validate functions ref within params [WIP]

* test invalid query params

Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com>
Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
jeffreylovitz pushed a commit that referenced this pull request Sep 10, 2021
* validate functions ref within params [WIP]

* test invalid query params

(cherry picked from commit 2e5b698)
jeffreylovitz pushed a commit that referenced this pull request Sep 10, 2021
* validate functions ref within params [WIP]

* test invalid query params

(cherry picked from commit 2e5b698)
swilly22 added a commit that referenced this pull request Sep 10, 2021
* cron task abort [WIP] (#1911)

* cron task abort [WIP]

* test task abort

* relaxed memory model synchronization modes

(cherry picked from commit add3c07)

* validate functions ref within params [WIP] (#1915)

* validate functions ref within params [WIP]

* test invalid query params

(cherry picked from commit 2e5b698)

* Update thread-local AST for every cloned op (#1913)

* Update thread-local AST for every cloned op

* address review

* add comment

* Update all_paths.c

Co-authored-by: Avi Avni <avi.avni@gmail.com>
Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
(cherry picked from commit 959ecc4)

* bump version to 2.8.4

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
pnxguide pushed a commit to CMU-SPEED/RedisGraph that referenced this pull request Mar 22, 2023
* validate functions ref within params [WIP]

* test invalid query params
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CRASH] redisgraph crashed
1 participant