Skip to content

Conversation

leonchen83
Copy link

pom
package name
git ignore
readme

pom
package name
git ignore
readme
Copy link
Contributor

@itamarhaber itamarhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇‍♂️

import redis.clients.jedis.Jedis;
import io.rejson.JReJSON;
import com.redislabs.modules.rejson.JReJSON;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know - naming things is hard... @dvirsky @dragnot - wdut?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically, package name same as maven group name. so I do above change

/.classpath

# Idea
/redis-replicator.iml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line looks a bit out of place :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy that file and miss modify name :)

@itamarhaber
Copy link
Contributor

Thanks so much - merging.

@itamarhaber itamarhaber merged commit 9abda43 into RedisJSON:master May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants