Skip to content
This repository was archived by the owner on Apr 20, 2020. It is now read-only.

add support for STRAPPEND, ARRAPPEND, ARRINSERT, ARRPOP, ARRINDEX, ARRTRIM, OBJKEYS #33

Merged
merged 66 commits into from
Aug 13, 2019
Merged

add support for STRAPPEND, ARRAPPEND, ARRINSERT, ARRPOP, ARRINDEX, ARRTRIM, OBJKEYS #33

merged 66 commits into from
Aug 13, 2019

Conversation

gkorland
Copy link
Contributor

No description provided.

gkorland added 4 commits July 21, 2019 01:23
@gkorland
1. json_del: backward fix on json_del to support full key delete
9fa668d 
2. json_set: error on creation of key with path!=root
3. mark commands as "write"  and open keys with open_key() on readonly
4. set_value: add support for root set and returns error when path not found
5. get_doc: return error on wrong path
@gkorland
fix comment
2bce063
@gkorland
1. redisjson.rs: turn num_op into a generic value_op
28d53fc 
2. lib.rs: add support for STRAPPEND, ARRAPPEND, ARRINSERT, ARRPOP
@gkorland
Merge branch 'gkor' of github.com:RedisLabsModules/RedisDoc into gkor
732bf01
@gkorland gkorland requested a review from gavrie July 22, 2019 14:34
@gkorland gkorland changed the title add support for STRAPPEND, ARRAPPEND, ARRINSERT, ARRPOP add support for STRAPPEND, ARRAPPEND, ARRINSERT, ARRPOP, ARRINDEX Jul 23, 2019
@gkorland gkorland changed the title add support for STRAPPEND, ARRAPPEND, ARRINSERT, ARRPOP, ARRINDEX add support for STRAPPEND, ARRAPPEND, ARRINSERT, ARRPOP, ARRINDEX, ARRTRIM Jul 23, 2019
@gkorland gkorland changed the title add support for STRAPPEND, ARRAPPEND, ARRINSERT, ARRPOP, ARRINDEX, ARRTRIM add support for STRAPPEND, ARRAPPEND, ARRINSERT, ARRPOP, ARRINDEX, ARRTRIM, OBJKEYS Jul 24, 2019
@gkorland
Copy link
Contributor Author

fix #13 #15

@gkorland
Copy link
Contributor Author

#ref 18 add support for RDB READ/WRITE

gavrie
gavrie suggested changes Aug 8, 2019
View reviewed changes
Copy link
Contributor

@gavrie gavrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my commits on your gkor branch in which I refactored the code to more idiomatic Rust; assuming we agree, the other methods should be refactored as well.

@gkorland
Copy link
Contributor Author

gkorland commented Aug 9, 2019

@gavrie It looks good thanks!

gavrie added 21 commits August 11, 2019 11:09
@gavrie
Use max/min methods
64588a0
@gavrie
More idiomatic code
d5e1122
@gavrie
cargo fmt
c53ae6a
@gavrie
Fix English grammar
26f18e7
@gavrie
Rename method for clarity
b79d9e3
@gavrie
More idiomatic code
6ec2048
@gavrie
More idiomatic code
533ec09
@gavrie
Cleanups
7a97f39
@gavrie
Factor out value calculations into separate functions
f59cdd2
@gavrie
Factor out value calculations into separate functions
c5c001d
@gavrie
Cleanups
3c65ce1
@gavrie
More idiomatic code
bbfd0fc
@gavrie
More idiomatic code
0ff8767
@gavrie
Fix one-off error
d0df709
@gavrie
Make value_op return Value instead of String so we can correctly dete…
2beea96 
…rmine the return value
@gavrie
Fix another one-off error
d05a2fc
@gavrie
json.arrinsert inserts items in original order (and not reversed)
553e304
@gavrie
Verify we have no superfluous command args
d9ebcdb
@gavrie
Normalize index offsets and fix another one-off error
bb351d7
@gavrie
Fix another range error
e4bff5b
@gavrie
Enable tests that pass
0ddebb4
@gkorland gkorland merged commit 95ed035 into master Aug 13, 2019
@gkorland gkorland deleted the gkor branch August 13, 2019 08:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@gavrie gavrie gavrie requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gkorland @gavrie